Re: [dpdk-dev] [PATCH] net: fix rte_vlan_insert with shared mbuf

2019-03-28 Thread Ferruh Yigit
On 3/27/2019 3:31 PM, Chas Williams wrote: > > > On 3/27/19 11:18 AM, Stephen Hemminger wrote: >> On Tue, 26 Mar 2019 18:38:57 -0400 >> Chas Williams <3ch...@gmail.com> wrote: >> >>> On 3/26/19 3:15 PM, Stephen Hemminger wrote: If mbuf refcnt was > 1 then rte_vlan_insert() would incorrectly

Re: [dpdk-dev] [PATCH] net: fix rte_vlan_insert with shared mbuf

2019-03-27 Thread Chas Williams
On 3/27/19 11:18 AM, Stephen Hemminger wrote: On Tue, 26 Mar 2019 18:38:57 -0400 Chas Williams <3ch...@gmail.com> wrote: On 3/26/19 3:15 PM, Stephen Hemminger wrote: If mbuf refcnt was > 1 then rte_vlan_insert() would incorrectly modify the original copy. Original code was expecting clone t

Re: [dpdk-dev] [PATCH] net: fix rte_vlan_insert with shared mbuf

2019-03-27 Thread Stephen Hemminger
On Tue, 26 Mar 2019 18:38:57 -0400 Chas Williams <3ch...@gmail.com> wrote: > On 3/26/19 3:15 PM, Stephen Hemminger wrote: > > If mbuf refcnt was > 1 then rte_vlan_insert() would incorrectly > > modify the original copy. Original code was expecting clone to make > > a copy (it doesn't). Better to l

Re: [dpdk-dev] [PATCH] net: fix rte_vlan_insert with shared mbuf

2019-03-26 Thread Chas Williams
On 3/26/19 3:15 PM, Stephen Hemminger wrote: If mbuf refcnt was > 1 then rte_vlan_insert() would incorrectly modify the original copy. Original code was expecting clone to make a copy (it doesn't). Better to let the caller deal with making a copy or setting up mbuf chain to allow for header to be

[dpdk-dev] [PATCH] net: fix rte_vlan_insert with shared mbuf

2019-03-26 Thread Stephen Hemminger
If mbuf refcnt was > 1 then rte_vlan_insert() would incorrectly modify the original copy. Original code was expecting clone to make a copy (it doesn't). Better to let the caller deal with making a copy or setting up mbuf chain to allow for header to be added. Also fix docbook comment about paramet