Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-16 Thread Ferruh Yigit
On 3/15/2017 6:19 PM, Jan Blunck wrote: > On Wed, Mar 15, 2017 at 1:35 PM, Charles (Chas) Williams > wrote: >> If the user reconfigures the queue size, then the previously allocated >> memzone may potentially be too small. Release the memzone when a queue >> is released and allocate a new one eac

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Shrikrishna Khare
On Wed, 15 Mar 2017, Yong Wang wrote: > > -Original Message- > > From: Charles (Chas) Williams [mailto:ciwil...@brocade.com] > > Sent: Wednesday, March 15, 2017 5:35 AM > > To: dev@dpdk.org > > Cc: Yong Wang ; Charles (Chas) Williams > > > > Subject: [PATCH] net/vmxnet3: fix queue size

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Jan Blunck
On Wed, Mar 15, 2017 at 1:35 PM, Charles (Chas) Williams wrote: > If the user reconfigures the queue size, then the previously allocated > memzone may potentially be too small. Release the memzone when a queue > is released and allocate a new one each time a queue is setup. > > While here convert

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Yong Wang
> -Original Message- > From: Charles (Chas) Williams [mailto:ciwil...@brocade.com] > Sent: Wednesday, March 15, 2017 5:35 AM > To: dev@dpdk.org > Cc: Yong Wang ; Charles (Chas) Williams > > Subject: [PATCH] net/vmxnet3: fix queue size changes > > If the user reconfigures the queue size, t

[dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Charles (Chas) Williams
If the user reconfigures the queue size, then the previously allocated memzone may potentially be too small. Release the memzone when a queue is released and allocate a new one each time a queue is setup. While here convert to rte_eth_dma_zone_reserve() which does basically the same things as the

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Charles (Chas) Williams
On 03/15/2017 06:05 AM, Jan Blunck wrote: On Wed, Mar 15, 2017 at 10:45 AM, Charles (Chas) Williams wrote: On 03/15/2017 04:18 AM, Jan Blunck wrote: On Tue, Mar 14, 2017 at 5:38 PM, Charles (Chas) Williams wrote: On 03/14/2017 12:11 PM, Jan Blunck wrote: On Mon, Mar 13, 2017 at 11

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Charles (Chas) Williams
On 03/15/2017 06:05 AM, Jan Blunck wrote: On Wed, Mar 15, 2017 at 10:45 AM, Charles (Chas) Williams wrote: On 03/15/2017 04:18 AM, Jan Blunck wrote: On Tue, Mar 14, 2017 at 5:38 PM, Charles (Chas) Williams wrote: On 03/14/2017 12:11 PM, Jan Blunck wrote: On Mon, Mar 13, 2017 at 11

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Jan Blunck
On Wed, Mar 15, 2017 at 10:45 AM, Charles (Chas) Williams wrote: > > > On 03/15/2017 04:18 AM, Jan Blunck wrote: >> >> On Tue, Mar 14, 2017 at 5:38 PM, Charles (Chas) Williams >> wrote: >>> >>> >>> >>> On 03/14/2017 12:11 PM, Jan Blunck wrote: On Mon, Mar 13, 2017 at 11:41 PM, Char

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Charles (Chas) Williams
On 03/15/2017 04:18 AM, Jan Blunck wrote: On Tue, Mar 14, 2017 at 5:38 PM, Charles (Chas) Williams wrote: On 03/14/2017 12:11 PM, Jan Blunck wrote: On Mon, Mar 13, 2017 at 11:41 PM, Charles (Chas) Williams wrote: If the user reconfigures the queues size, then the previosly allocated me

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Jan Blunck
On Tue, Mar 14, 2017 at 5:38 PM, Charles (Chas) Williams wrote: > > > On 03/14/2017 12:11 PM, Jan Blunck wrote: >> >> On Mon, Mar 13, 2017 at 11:41 PM, Charles (Chas) Williams >> wrote: >>> >>> If the user reconfigures the queues size, then the previosly allocated >>> memzone may potentially be t

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-14 Thread Charles (Chas) Williams
On 03/14/2017 12:11 PM, Jan Blunck wrote: On Mon, Mar 13, 2017 at 11:41 PM, Charles (Chas) Williams wrote: If the user reconfigures the queues size, then the previosly allocated memzone may potentially be too small. Instead, always free the old memzone and allocate a new one. Fixes: dfaff37

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-14 Thread Jan Blunck
On Mon, Mar 13, 2017 at 11:41 PM, Charles (Chas) Williams wrote: > If the user reconfigures the queues size, then the previosly allocated > memzone may potentially be too small. Instead, always free the old > memzone and allocate a new one. > > Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 po

[dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-13 Thread Charles (Chas) Williams
If the user reconfigures the queues size, then the previosly allocated memzone may potentially be too small. Instead, always free the old memzone and allocate a new one. Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver implementation") Signed-off-by: Chas Williams --- driver