Re: [dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized

2017-04-13 Thread Tan, Jianfeng
On 4/13/2017 10:36 AM, Yuanhan Liu wrote: On Thu, Apr 13, 2017 at 10:18:43AM +0800, Tan, Jianfeng wrote: On 4/13/2017 9:58 AM, Yuanhan Liu wrote: On Fri, Apr 07, 2017 at 07:57:40AM +, Jianfeng Tan wrote: After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled by default. Actua

Re: [dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized

2017-04-13 Thread Tan, Jianfeng
On 4/13/2017 10:21 AM, Yuanhan Liu wrote: On Thu, Apr 13, 2017 at 10:18:43AM +0800, Tan, Jianfeng wrote: On 4/13/2017 9:58 AM, Yuanhan Liu wrote: On Fri, Apr 07, 2017 at 07:57:40AM +, Jianfeng Tan wrote: After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled by default. Howeve

Re: [dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized

2017-04-12 Thread Yuanhan Liu
On Thu, Apr 13, 2017 at 10:18:43AM +0800, Tan, Jianfeng wrote: > > > On 4/13/2017 9:58 AM, Yuanhan Liu wrote: > >On Fri, Apr 07, 2017 at 07:57:40AM +, Jianfeng Tan wrote: > >>After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled > >>by default. Actually, that's my point. The vhost

Re: [dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized

2017-04-12 Thread Yuanhan Liu
On Thu, Apr 13, 2017 at 10:18:43AM +0800, Tan, Jianfeng wrote: > > > On 4/13/2017 9:58 AM, Yuanhan Liu wrote: > >On Fri, Apr 07, 2017 at 07:57:40AM +, Jianfeng Tan wrote: > >>After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled > >>by default. However, virtio-user vtpci does not s

Re: [dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized

2017-04-12 Thread Tan, Jianfeng
On 4/13/2017 9:58 AM, Yuanhan Liu wrote: On Fri, Apr 07, 2017 at 07:57:40AM +, Jianfeng Tan wrote: After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled by default. However, virtio-user vtpci does not support to get MTU from device yet, i.e., vtpci_read_dev_config(MTU) fails. Pl

Re: [dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized

2017-04-12 Thread Yuanhan Liu
On Fri, Apr 07, 2017 at 07:57:40AM +, Jianfeng Tan wrote: > After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled > by default. However, virtio-user vtpci does not support to get > MTU from device yet, i.e., vtpci_read_dev_config(MTU) fails. > Plus, struct virtio_net_config is define

[dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized

2017-04-07 Thread Jianfeng Tan
After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled by default. However, virtio-user vtpci does not support to get MTU from device yet, i.e., vtpci_read_dev_config(MTU) fails. Plus, struct virtio_net_config is defined as a uninitialized variable, and could be different values in virtio