Re: [dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback

2019-11-21 Thread Ferruh Yigit
On 11/21/2019 12:55 AM, Maxime Coquelin wrote: > > > On 11/19/19 8:12 AM, Tiwei Bie wrote: >> The "addr" param has been used since the event callbacks are enabled >> for external memory. So the "__rte_unused" should be dropped. >> >> Besides, slightly refine the coding style by consistently assum

Re: [dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback

2019-11-21 Thread Ferruh Yigit
On 11/21/2019 12:09 PM, Burakov, Anatoly wrote: > On 21-Nov-19 8:58 AM, Ferruh Yigit wrote: >> On 11/21/2019 12:55 AM, Maxime Coquelin wrote: >>> >>> >>> On 11/19/19 8:12 AM, Tiwei Bie wrote: The "addr" param has been used since the event callbacks are enabled for external memory. So the

Re: [dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback

2019-11-21 Thread Burakov, Anatoly
On 21-Nov-19 8:58 AM, Ferruh Yigit wrote: On 11/21/2019 12:55 AM, Maxime Coquelin wrote: On 11/19/19 8:12 AM, Tiwei Bie wrote: The "addr" param has been used since the event callbacks are enabled for external memory. So the "__rte_unused" should be dropped. Besides, slightly refine the codin

Re: [dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback

2019-11-21 Thread Ferruh Yigit
On 11/21/2019 12:55 AM, Maxime Coquelin wrote: > > > On 11/19/19 8:12 AM, Tiwei Bie wrote: >> The "addr" param has been used since the event callbacks are enabled >> for external memory. So the "__rte_unused" should be dropped. >> >> Besides, slightly refine the coding style by consistently assum

Re: [dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback

2019-11-20 Thread Maxime Coquelin
On 11/19/19 8:12 AM, Tiwei Bie wrote: > The "addr" param has been used since the event callbacks are enabled > for external memory. So the "__rte_unused" should be dropped. > > Besides, slightly refine the coding style by consistently assuming > tabs are 8 characters. > > Fixes: f32c7c9de961 (

[dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback

2019-11-18 Thread Tiwei Bie
The "addr" param has been used since the event callbacks are enabled for external memory. So the "__rte_unused" should be dropped. Besides, slightly refine the coding style by consistently assuming tabs are 8 characters. Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory") C