Re: [dpdk-dev] [PATCH] net/virtio: fix wrong TX pkt length stats

2017-10-17 Thread Yuanhan Liu
On Wed, Oct 11, 2017 at 12:39:35PM +0800, Zhiyong Yang wrote: > In the function virtqueue_enqueue_xmit(), when can_push == 1 is true, > vtnet_hdr_size is added to pkt_len by calling rte_pktmbuf_prepend. > So, virtio header len should be subtracted before calling stats > function. Nice catch! > Fi

Re: [dpdk-dev] [PATCH] net/virtio: fix wrong TX pkt length stats

2017-10-13 Thread Maxime Coquelin
On 10/13/2017 02:44 PM, Yang, Zhiyong wrote: Hi Maxime, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Friday, October 13, 2017 6:06 PM To: Yang, Zhiyong ; dev@dpdk.org Cc: y...@fridaylinux.org; Tan, Jianfeng Subject: Re: [PATCH] net/virtio: fix wr

Re: [dpdk-dev] [PATCH] net/virtio: fix wrong TX pkt length stats

2017-10-13 Thread Yang, Zhiyong
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, October 13, 2017 6:06 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: y...@fridaylinux.org; Tan, Jianfeng > Subject: Re: [PATCH] net/virtio: fix wrong TX pkt length stats > > Hi Zhiyon

Re: [dpdk-dev] [PATCH] net/virtio: fix wrong TX pkt length stats

2017-10-13 Thread Maxime Coquelin
Hi Zhiyong, On 10/11/2017 06:39 AM, Zhiyong Yang wrote: In the function virtqueue_enqueue_xmit(), when can_push == 1 is true, vtnet_hdr_size is added to pkt_len by calling rte_pktmbuf_prepend. So, virtio header len should be subtracted before calling stats function. Fixes: 58169a9c8153 ("net/vi

[dpdk-dev] [PATCH] net/virtio: fix wrong TX pkt length stats

2017-10-10 Thread Zhiyong Yang
In the function virtqueue_enqueue_xmit(), when can_push == 1 is true, vtnet_hdr_size is added to pkt_len by calling rte_pktmbuf_prepend. So, virtio header len should be subtracted before calling stats function. Fixes: 58169a9c8153 ("net/virtio: support Tx checksum offload") Signed-off-by: Zhiyong