Re: [dpdk-dev] [PATCH] net/vhost: fix xstats wrong after clearing stats

2020-10-06 Thread Maxime Coquelin
On 10/5/20 7:43 PM, David Christensen wrote: > > > On 9/23/20 1:07 AM, Maxime Coquelin wrote: >> Hi David, >> >> Could you please post a v2 with Chenbo's comments taken into account? > > Sorry, been out of the office for a bit but now working through my > backlog. I did make the change but di

Re: [dpdk-dev] [PATCH] net/vhost: fix xstats wrong after clearing stats

2020-10-05 Thread David Christensen
On 9/23/20 1:07 AM, Maxime Coquelin wrote: Hi David, Could you please post a v2 with Chenbo's comments taken into account? Sorry, been out of the office for a bit but now working through my backlog. I did make the change but discovered there were additional dependencies between stats and

Re: [dpdk-dev] [PATCH] net/vhost: fix xstats wrong after clearing stats

2020-09-23 Thread Maxime Coquelin
Hi David, Could you please post a v2 with Chenbo's comments taken into account? Thanks, Maxime On 9/11/20 9:44 AM, Xia, Chenbo wrote: > Hi David, > > Thanks for working on this. Comments inline. > >> -Original Message- >> From: David Christensen >> Sent: Thursday, September 3, 2020 1:

Re: [dpdk-dev] [PATCH] net/vhost: fix xstats wrong after clearing stats

2020-09-11 Thread Xia, Chenbo
Hi David, Thanks for working on this. Comments inline. > -Original Message- > From: David Christensen > Sent: Thursday, September 3, 2020 1:03 AM > To: maxime.coque...@redhat.com; Xia, Chenbo ; Wang, > Zhihong ; dev@dpdk.org > Cc: David Christensen > Subject: [PATCH] net/vhost: fix xsta

[dpdk-dev] [PATCH] net/vhost: fix xstats wrong after clearing stats

2020-09-02 Thread David Christensen
The PMD API allows stats and xstats values to be cleared separately. This is a problem for the vhost PMD since some of the xstats values are derived from existing stats values. For example: testpmd> show port xstats all ... tx_unicast_packets: 17562959 ... testpmd> clear port stats all ... show p