Re: [dpdk-dev] [PATCH] net/vhost: fix vhost invalid state

2018-04-10 Thread Chen, Junjie J
OWN; Will send out V2 to include this. Cheers JJ > -Original Message- > From: Jens Freimann [mailto:jfreim...@redhat.com] > Sent: Tuesday, April 10, 2018 7:13 PM > To: Chen, Junjie J > Cc: Tan, Jianfeng ; maxime.coque...@redhat.com; > mtetsu...@gmail.com; dev@dpdk.org >

Re: [dpdk-dev] [PATCH] net/vhost: fix vhost invalid state

2018-04-10 Thread Jens Freimann
On Tue, Apr 10, 2018 at 10:18:09AM -0400, Junjie Chen wrote: dev_start sets *dev_attached* after setup queues, this sets device to invalid state since no frontend is attached. Also destroy_device set *started* to zero which makes *allow_queuing* always zero until dev_start get called again. Actua

Re: [dpdk-dev] [PATCH] net/vhost: fix vhost invalid state

2018-04-10 Thread Tan, Jianfeng
Hi Junjie, I think the code is still buggy. As vhost thread and master thread are separately invoking new_device() and dev_start(). On 4/10/2018 10:18 PM, Junjie Chen wrote: dev_start sets *dev_attached* after setup queues, this sets device to invalid state since no frontend is attached. Also

[dpdk-dev] [PATCH] net/vhost: fix vhost invalid state

2018-04-09 Thread Junjie Chen
dev_start sets *dev_attached* after setup queues, this sets device to invalid state since no frontend is attached. Also destroy_device set *started* to zero which makes *allow_queuing* always zero until dev_start get called again. Actually, we should not determine queues existence by *dev_attached*