Re: [dpdk-dev] [PATCH] net/vdev_netvsc: fix erronous cast

2019-03-25 Thread Ferruh Yigit
On 3/17/2019 6:16 AM, Matan Azrad wrote: > Hi > > From: Stephen Hemminger >>> Hi >>> >>> From: Stephen Hemminger The return value from bus->find_device is a rte_device which is not safe to cast to a rte_vdev_device structure. It doesn't really matter since only being checked for NUL

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: fix erronous cast

2019-03-16 Thread Matan Azrad
Hi From: Stephen Hemminger > > Hi > > > > From: Stephen Hemminger > > > The return value from bus->find_device is a rte_device which is not > > > safe to cast to a rte_vdev_device structure. > > > It doesn't really matter since only being checked for NULL but > > > static checkers might find a bug

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: fix erronous cast

2019-03-14 Thread Stephen Hemminger
On Thu, 14 Mar 2019 11:13:10 + Matan Azrad wrote: > Hi > > From: Stephen Hemminger > > The return value from bus->find_device is a rte_device which is not safe to > > cast to a rte_vdev_device structure. > > It doesn't really matter since only being checked for NULL but static > > checkers

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: fix erronous cast

2019-03-14 Thread Matan Azrad
Hi From: Stephen Hemminger > The return value from bus->find_device is a rte_device which is not safe to > cast to a rte_vdev_device structure. > It doesn't really matter since only being checked for NULL but static checkers > might find a bug here. > Fix line is missing. > Signed-off-by: Steph

[dpdk-dev] [PATCH] net/vdev_netvsc: fix erronous cast

2019-03-12 Thread Stephen Hemminger
The return value from bus->find_device is a rte_device which is not safe to cast to a rte_vdev_device structure. It doesn't really matter since only being checked for NULL but static checkers might find a bug here. Signed-off-by: Stephen Hemminger --- drivers/net/vdev_netvsc/vdev_netvsc.c | 7 ++