Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

On 7/9/2018 11:01 PM, Wiles, Keith wrote: > > >> On Jul 9, 2018, at 3:20 PM, Eads, Gage wrote: >> >> Set the rx and tx queue state appropriately when the queues or device are >> started or stopped. >> >> Signed-off-by: Gage Eads > > Acked-by Keith Wiles Applied to dpdk-next-net/master, thank

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

> -Original Message- > From: Wiles, Keith > Sent: Monday, July 9, 2018 5:07 PM > To: Eads, Gage > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped > > > > > On Jul 9, 2018, at 5:00 PM, Wiles, Keith wrote: &g

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

> On Jul 9, 2018, at 5:00 PM, Wiles, Keith wrote: > > > >> On Jul 9, 2018, at 4:51 PM, Eads, Gage wrote: >> >> >> +static int +tap_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) +{ + dev->data->rx_queue_state[rx_queue_id] = >>> RTE_ETH_QUEUE_STAT

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

> On Jul 9, 2018, at 3:20 PM, Eads, Gage wrote: > > Set the rx and tx queue state appropriately when the queues or device are > started or stopped. > > Signed-off-by: Gage Eads Acked-by Keith Wiles Regards, Keith

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

> On Jul 9, 2018, at 4:51 PM, Eads, Gage wrote: > > > >>> >>> +static int >>> +tap_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) >>> +{ >>> + dev->data->rx_queue_state[rx_queue_id] = >> RTE_ETH_QUEUE_STATE_STARTED; >> >> We need to verify the rx_queue_id is valid before s

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

> > > > +static int > > +tap_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) > > +{ > > + dev->data->rx_queue_state[rx_queue_id] = > RTE_ETH_QUEUE_STATE_STARTED; > > We need to verify the rx_queue_id is valid before setting the state. > > if (rx_queue_id < dev->data>nb_rx_queues

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

> On Jul 9, 2018, at 3:20 PM, Eads, Gage wrote: > > Set the rx and tx queue state appropriately when the queues or device are > started or stopped. > > Signed-off-by: Gage Eads > --- > drivers/net/tap/rte_eth_tap.c | 56 +-- > 1 file changed, 54 inserti

[dpdk-dev] [PATCH] net/tap: set queue started and stopped

Set the rx and tx queue state appropriately when the queues or device are started or stopped. Signed-off-by: Gage Eads --- drivers/net/tap/rte_eth_tap.c | 56 +-- 1 file changed, 54 insertions(+), 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c