Re: [dpdk-dev] [PATCH] net/tap: perform proto field update for tun only

2018-05-15 Thread Varghese, Vipin
Thanks Keith, I have made changes and shared v2 patch for both the suggestions. Thanks Vipin Varghese > > + /* > > +* TUN and TAP are created with IFF_NO_PI disabled. > > +* For TUN PMD this mandatory as fields are used by > > +

Re: [dpdk-dev] [PATCH] net/tap: perform proto field update for tun only

2018-05-14 Thread Wiles, Keith
> On May 13, 2018, at 11:53 PM, Vipin Varghese wrote: > > The TX function is shared between TAP and TUN PMD. Checking TUN-TAP > type field will ensure the TAP PMD will always have protocol field as 0. > > Signed-off-by: Vipin Varghese > --- > drivers/net/tap/rte_eth_tap.c | 50 +++

[dpdk-dev] [PATCH] net/tap: perform proto field update for tun only

2018-05-13 Thread Vipin Varghese
The TX function is shared between TAP and TUN PMD. Checking TUN-TAP type field will ensure the TAP PMD will always have protocol field as 0. Signed-off-by: Vipin Varghese --- drivers/net/tap/rte_eth_tap.c | 50 +++ drivers/net/tap/rte_eth_tap.h | 10 ++