Re: [dpdk-dev] [PATCH] net/tap: fix the vdev data sharing for tun

On 5/15/2018 1:56 PM, Varghese, Vipin wrote: > HI Keith, > > Thanks for the input, please find my answer inline to email therad > > > >>> + /* TODO: request info from primary to set up Rx and Tx */ >> >> What is the rule (if we have one) about having TODO, FIXME, … like comments >> i

Re: [dpdk-dev] [PATCH] net/tap: fix the vdev data sharing for tun

HI Keith, Thanks for the input, please find my answer inline to email therad > > + /* TODO: request info from primary to set up Rx and Tx */ > > What is the rule (if we have one) about having TODO, FIXME, … like comments in > the code? Maybe remove the todo and create a enhancement r

Re: [dpdk-dev] [PATCH] net/tap: fix the vdev data sharing for tun

> On May 12, 2018, at 1:37 AM, Vipin Varghese wrote: > > Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") > > Enables TUN PMD sharing by attaching the port from the shared data. > > Cc: zhihong.w...@intel.com > Cc: ferruh.yi...@intel.com > > Signed-off-by: Vipin Varg

[dpdk-dev] [PATCH] net/tap: fix the vdev data sharing for tun

Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") Enables TUN PMD sharing by attaching the port from the shared data. Cc: zhihong.w...@intel.com Cc: ferruh.yi...@intel.com Signed-off-by: Vipin Varghese --- --- drivers/net/tap/rte_eth_tap.c | 13 + 1 file cha