Re: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters

2019-08-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of David Christensen > Sent: Thursday, August 1, 2019 1:41 AM > To: Slava Ovsiienko > Cc: dev@dpdk.org; David Christensen > Subject: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX- > 5 adapt

Re: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters

2019-08-03 Thread Slava Ovsiienko
> -Original Message- > From: David Christensen > Sent: Friday, August 2, 2019 21:18 > To: Slava Ovsiienko > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 > adapters > > >>> Yes, thank you for the patch, acked. > >>> > >>> The "txq_inline_min" val

Re: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters

2019-08-02 Thread David Christensen
Yes, thank you for the patch, acked. The "txq_inline_min" value was not set for ConnectX-5 to 0 as default. At the TX queue setup time the "txq_inline_min" is checked against MLX5_ARG_UNSET and default value 0 is set: txq_set_params() ... inlen_mode = (config->txq_inline_min == MLX5_ARG_UNSET) ?

Re: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters

2019-08-01 Thread Slava Ovsiienko
> -Original Message- > From: David Christensen > Sent: Thursday, August 1, 2019 21:24 > To: Slava Ovsiienko > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 > adapters > > > Yes, thank you for the patch, acked. > > > > The "txq_inline_min" value w

Re: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters

2019-08-01 Thread David Christensen
Yes, thank you for the patch, acked. The "txq_inline_min" value was not set for ConnectX-5 to 0 as default. At the TX queue setup time the "txq_inline_min" is checked against MLX5_ARG_UNSET and default value 0 is set: txq_set_params() ... inlen_mode = (config->txq_inline_min == MLX5_ARG_UNSET)

Re: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters

2019-07-31 Thread Slava Ovsiienko
Hi, David Yes, thank you for the patch, acked. The "txq_inline_min" value was not set for ConnectX-5 to 0 as default. At the TX queue setup time the "txq_inline_min" is checked against MLX5_ARG_UNSET and default value 0 is set: txq_set_params() ... inlen_mode = (config->txq_inline_min == MLX5_

Re: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters

2019-07-31 Thread Stephen Hemminger
On Wed, 31 Jul 2019 17:41:11 -0500 David Christensen wrote: > The function mlx5_set_min_inline() includes a switch() that checks > various PCI device IDs in order to set the txq_inline_min value. No > value is set when the PCI device ID matches the ConnectX-5 adapters, > resulting in an assert()

[dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters

2019-07-31 Thread David Christensen
The function mlx5_set_min_inline() includes a switch() that checks various PCI device IDs in order to set the txq_inline_min value. No value is set when the PCI device ID matches the ConnectX-5 adapters, resulting in an assert() failure later in the function mlx5_set_txlimit_params(). This error