Re: [dpdk-dev] [PATCH] net/mlx5: poll completion queue once per a call

2017-07-31 Thread Ferruh Yigit
On 7/20/2017 4:48 PM, Yongseok Koh wrote: > mlx5_tx_complete() polls completion queue multiple times until it > encounters an invalid entry. As Tx completions are suppressed by > MLX5_TX_COMP_THRESH, it is waste of cycles to expect multiple completions > in a poll. And freeing too many buffers in a

Re: [dpdk-dev] [PATCH] net/mlx5: poll completion queue once per a call

2017-07-27 Thread Yongseok Koh
> On Jul 27, 2017, at 4:12 AM, Sagi Grimberg wrote: > > >>> Yes I realize that, but can't the device still complete in a burst (of >>> unsuppressed completions)? I mean its not guaranteed that for every >>> txq_complete a signaled completion is pending right? What happens if >>> the device has

Re: [dpdk-dev] [PATCH] net/mlx5: poll completion queue once per a call

2017-07-27 Thread Sagi Grimberg
Yes I realize that, but can't the device still complete in a burst (of unsuppressed completions)? I mean its not guaranteed that for every txq_complete a signaled completion is pending right? What happens if the device has inconsistent completion pacing? Can't the sw grow a batch of completions

Re: [dpdk-dev] [PATCH] net/mlx5: poll completion queue once per a call

2017-07-25 Thread Yongseok Koh
On Sun, Jul 23, 2017 at 12:49:36PM +0300, Sagi Grimberg wrote: > > > > mlx5_tx_complete() polls completion queue multiple times until it > > > > encounters an invalid entry. As Tx completions are suppressed by > > > > MLX5_TX_COMP_THRESH, it is waste of cycles to expect multiple > > > > completion

Re: [dpdk-dev] [PATCH] net/mlx5: poll completion queue once per a call

2017-07-23 Thread Sagi Grimberg
mlx5_tx_complete() polls completion queue multiple times until it encounters an invalid entry. As Tx completions are suppressed by MLX5_TX_COMP_THRESH, it is waste of cycles to expect multiple completions in a poll. And freeing too many buffers in a call can cause high jitter. This patch improves

Re: [dpdk-dev] [PATCH] net/mlx5: poll completion queue once per a call

2017-07-21 Thread Yongseok Koh
On Thu, Jul 20, 2017 at 07:34:04PM +0300, Sagi Grimberg wrote: > > > mlx5_tx_complete() polls completion queue multiple times until it > > encounters an invalid entry. As Tx completions are suppressed by > > MLX5_TX_COMP_THRESH, it is waste of cycles to expect multiple completions > > in a poll. A

Re: [dpdk-dev] [PATCH] net/mlx5: poll completion queue once per a call

2017-07-20 Thread Sagi Grimberg
mlx5_tx_complete() polls completion queue multiple times until it encounters an invalid entry. As Tx completions are suppressed by MLX5_TX_COMP_THRESH, it is waste of cycles to expect multiple completions in a poll. And freeing too many buffers in a call can cause high jitter. This patch improve

[dpdk-dev] [PATCH] net/mlx5: poll completion queue once per a call

2017-07-20 Thread Yongseok Koh
mlx5_tx_complete() polls completion queue multiple times until it encounters an invalid entry. As Tx completions are suppressed by MLX5_TX_COMP_THRESH, it is waste of cycles to expect multiple completions in a poll. And freeing too many buffers in a call can cause high jitter. This patch improves t