Re: [dpdk-dev] [PATCH] net/mlx5: handle expected errno properly

2018-08-31 Thread Yongseok Koh
> On Aug 28, 2018, at 8:52 PM, Jack Min wrote: > > On Tue, Aug 28, 2018 at 01:42:18PM -0700, Yongseok Koh wrote: >> On Fri, Aug 24, 2018 at 02:45:00PM +0800, Jack MIN wrote: >>> On Thu, Aug 23, 2018 at 02:08:09PM -0700, Yongseok Koh wrote: On Thu, Aug 23, 2018 at 02:38:51PM +0800, Xiaoyu M

Re: [dpdk-dev] [PATCH] net/mlx5: handle expected errno properly

2018-08-28 Thread Jack MIN
On Tue, Aug 28, 2018 at 01:42:18PM -0700, Yongseok Koh wrote: > On Fri, Aug 24, 2018 at 02:45:00PM +0800, Jack MIN wrote: > > On Thu, Aug 23, 2018 at 02:08:09PM -0700, Yongseok Koh wrote: > > > On Thu, Aug 23, 2018 at 02:38:51PM +0800, Xiaoyu Min wrote: > > > > rte_errno is a per thread variable an

Re: [dpdk-dev] [PATCH] net/mlx5: handle expected errno properly

2018-08-28 Thread Yongseok Koh
On Fri, Aug 24, 2018 at 02:45:00PM +0800, Jack MIN wrote: > On Thu, Aug 23, 2018 at 02:08:09PM -0700, Yongseok Koh wrote: > > On Thu, Aug 23, 2018 at 02:38:51PM +0800, Xiaoyu Min wrote: > > > rte_errno is a per thread variable and is widely used as an > > > error indicator, which means a function c

Re: [dpdk-dev] [PATCH] net/mlx5: handle expected errno properly

2018-08-23 Thread Jack MIN
On Thu, Aug 23, 2018 at 02:08:09PM -0700, Yongseok Koh wrote: > On Thu, Aug 23, 2018 at 02:38:51PM +0800, Xiaoyu Min wrote: > > rte_errno is a per thread variable and is widely used as an > > error indicator, which means a function could affect > > other functions' results by setting rte_errno care

Re: [dpdk-dev] [PATCH] net/mlx5: handle expected errno properly

2018-08-23 Thread Yongseok Koh
On Thu, Aug 23, 2018 at 02:38:51PM +0800, Xiaoyu Min wrote: > rte_errno is a per thread variable and is widely used as an > error indicator, which means a function could affect > other functions' results by setting rte_errno carelessly > > During rxq setup, an EINVAL rte_errno is expected since >

[dpdk-dev] [PATCH] net/mlx5: handle expected errno properly

2018-08-22 Thread Xiaoyu Min
rte_errno is a per thread variable and is widely used as an error indicator, which means a function could affect other functions' results by setting rte_errno carelessly During rxq setup, an EINVAL rte_errno is expected since the queues are not created yet So rte_errno is cleared when it is EINVAL