Re: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header

2019-11-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Friday, November 1, 2019 3:33 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Moti Haimovsky > Subject: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN &g

Re: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header

2019-11-01 Thread Slava Ovsiienko
> -Original Message- > From: Xiaoyu Min > Sent: Friday, November 1, 2019 3:33 > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Moti Haimovsky > Subject: [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header > > Currently if user want to set VLAN id/pcp on an

[dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header

2019-10-31 Thread Xiaoyu Min
Currently if user want to set VLAN id/pcp on an about to be pushed VLAN header, the of_set_vlan_vid/of_set_vlan_pcp must be present _before_ action of_push_vlan: [1] ... actions of_set_vlan_vid vlan_vid 2 / of_push_vlan ... This is misleading because people think rule [1] intends to set VLAN id o