Re: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

2018-07-25 Thread Shahaf Shuler
Wednesday, July 25, 2018 9:59 AM, Nélio Laranjeiro: > Subject: Re: [PATCH] net/mlx5: fix possible endless loop when clearing flow > flags > > On Tue, Jul 24, 2018 at 09:47:19PM +, Yongseok Koh wrote: > > > > > On Jul 23, 2018, at 11:57 PM, Nélio Laranjeiro > wrote: > > > > > > On Mon, Jul 23,

Re: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

2018-07-24 Thread Nélio Laranjeiro
On Tue, Jul 24, 2018 at 09:47:19PM +, Yongseok Koh wrote: > > > On Jul 23, 2018, at 11:57 PM, Nélio Laranjeiro > > wrote: > > > > On Mon, Jul 23, 2018 at 11:27:44AM -0700, Yongseok Koh wrote: > >> If one of (*priv->rxqs)[] is null, the for loop can iterate infinitely as > >> idx can't be in

Re: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

2018-07-24 Thread Yongseok Koh
> On Jul 23, 2018, at 11:57 PM, Nélio Laranjeiro > wrote: > > On Mon, Jul 23, 2018 at 11:27:44AM -0700, Yongseok Koh wrote: >> If one of (*priv->rxqs)[] is null, the for loop can iterate infinitely as >> idx can't be increased. >> >> Fixes: cd24d526395e ("net/mlx5: add mark/flag flow action")

Re: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

2018-07-23 Thread Nélio Laranjeiro
On Mon, Jul 23, 2018 at 11:27:44AM -0700, Yongseok Koh wrote: > If one of (*priv->rxqs)[] is null, the for loop can iterate infinitely as > idx can't be increased. > > Fixes: cd24d526395e ("net/mlx5: add mark/flag flow action") > Cc: Nelio Laranjeiro > > Signed-off-by: Yongseok Koh > --- > dri

Re: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

2018-07-23 Thread Ori Kam
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh > Sent: Monday, July 23, 2018 9:28 PM > To: Shahaf Shuler > Cc: dev@dpdk.org; Yongseok Koh ; Nélio Laranjeiro > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix possible endless

[dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

2018-07-23 Thread Yongseok Koh
If one of (*priv->rxqs)[] is null, the for loop can iterate infinitely as idx can't be increased. Fixes: cd24d526395e ("net/mlx5: add mark/flag flow action") Cc: Nelio Laranjeiro Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 8 +++- 1 file changed, 3 insertions(+), 5 delet