Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

2018-07-25 Thread Yaroslav Brustinov (ybrustin)
Hi, Sounds good to me. Thanks, Yaroslav. -Original Message- From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] Sent: Wednesday, July 25, 2018 12:25 To: Yaroslav Brustinov (ybrustin) Cc: Shahaf Shuler ; Yongseok Koh ; dev@dpdk.org; sta...@dpdk.org; Nélio Laranjeiro ; Hanoch H

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

2018-07-25 Thread Yaroslav Brustinov (ybrustin)
+Hanoch I've added -std=c11 flag to our compilation to check. Without alignas(max_align_t): /usr/bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in src/dpdk/drivers/net/mlx5/mlx5_glue.c.11.o is smaller than 32 in src/dpdk/drivers/net/mlx5/mlx5_rxq.c.11.o With alignas(max_align_t): /usr/bin/

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

2018-07-25 Thread Yaroslav Brustinov (ybrustin)
Hi, Are you OK with C11? I saw in file dpdk/drivers/net/mlx4/mlx4_utils.c: * C11 code would include stdalign.h and use alignof(max_align_t) however * we'll stick with C99 for the time being. :) As far as I understand, the issue is alignment of the pointer itself, not the struct. I'm

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

2018-07-25 Thread Adrien Mazarguil
On Wed, Jul 25, 2018 at 07:38:39AM +, Yaroslav Brustinov (ybrustin) wrote: > +Hanoch > > I've added -std=c11 flag to our compilation to check. > > Without alignas(max_align_t): > /usr/bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in > src/dpdk/drivers/net/mlx5/mlx5_glue.c.11.o is smalle

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

2018-07-24 Thread Adrien Mazarguil
On Tue, Jul 24, 2018 at 02:24:12PM +, Yaroslav Brustinov (ybrustin) wrote: > Hi, > > Are you OK with C11? > I saw in file dpdk/drivers/net/mlx4/mlx4_utils.c: > > * C11 code would include stdalign.h and use alignof(max_align_t) however > * we'll stick with C99 for the time being. >

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

2018-07-24 Thread Shahaf Shuler
Yaroslav, Tuesday, July 24, 2018 3:06 PM, Adrien Mazarguil: > Subject: Re: [PATCH] net/mlx5: fix linkage error for glue lib > > Odd, how could this happen assuming both files are compiled during the > > same run using identical flags? Looks like a compiler issue. > > > > Anyway, may I suggest an

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

2018-07-24 Thread Adrien Mazarguil
On Tue, Jul 24, 2018 at 02:00:48PM +0200, Adrien Mazarguil wrote: > On Tue, Jul 24, 2018 at 11:54:45AM +0300, Shahaf Shuler wrote: > > From: Yaroslav Brustinov > > > > Compiling with gcc 4.7.2 introduced the linkage error > > > > "bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in > > src/dpd

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

2018-07-24 Thread Adrien Mazarguil
On Tue, Jul 24, 2018 at 11:54:45AM +0300, Shahaf Shuler wrote: > From: Yaroslav Brustinov > > Compiling with gcc 4.7.2 introduced the linkage error > > "bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in > src/dpdk/drivers/net/mlx5/mlx5_glue.c.21.o is smaller than 16 in > src/dpdk/drivers/net

[dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

2018-07-24 Thread Shahaf Shuler
From: Yaroslav Brustinov Compiling with gcc 4.7.2 introduced the linkage error "bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in src/dpdk/drivers/net/mlx5/mlx5_glue.c.21.o is smaller than 16 in src/dpdk/drivers/net/mlx5/mlx5_rxq.c.21.o" Fix it be forcing the alignment of the glue lib. Fix