Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid error check

2018-06-27 Thread Shahaf Shuler
Wednesday, June 27, 2018 2:55 PM, Nélio Laranjeiro: > Subject: Re: [PATCH] net/mlx5: fix invalid error check > > On Wed, Jun 27, 2018 at 11:20:52AM +0200, Adrien Mazarguil wrote: > > Since its return type is unsigned, if_nametoindex() returns 0 in case > > of error, never -1. > > > > Fixes: ccdcba

Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid error check

2018-06-27 Thread Nélio Laranjeiro
On Wed, Jun 27, 2018 at 11:20:52AM +0200, Adrien Mazarguil wrote: > Since its return type is unsigned, if_nametoindex() returns 0 in case of > error, never -1. > > Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") > Cc: Nelio Laranjeiro > Cc: sta...@dpdk.org > > Signed-of

[dpdk-dev] [PATCH] net/mlx5: fix invalid error check

2018-06-27 Thread Adrien Mazarguil
Since its return type is unsigned, if_nametoindex() returns 0 in case of error, never -1. Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") Cc: Nelio Laranjeiro Cc: sta...@dpdk.org Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_ethdev.c | 4 ++-- 1 file chang