Re: [dpdk-dev] [PATCH] net/mlx5: fix error number handling

2018-06-20 Thread Nélio Laranjeiro
On Tue, Jun 19, 2018 at 11:00:25PM +, Yongseok Koh wrote: >[...] > >>> I did not understood it was only a concern about the success of the > >>> function, even it is better to avoid as most as possible a useless > >>> store, in this specific case, as errno (rte_errno) has a garbage value, > >>>

Re: [dpdk-dev] [PATCH] net/mlx5: fix error number handling

2018-06-19 Thread Yongseok Koh
> On Jun 19, 2018, at 4:48 AM, Nélio Laranjeiro > wrote: > > On Mon, Jun 18, 2018 at 05:06:41PM +, Yongseok Koh wrote: >> >>> On Jun 7, 2018, at 12:39 AM, Nélio Laranjeiro >>> wrote: >>> >>> On Wed, Jun 06, 2018 at 11:39:27AM -0700, Yongseok Koh wrote: On Wed, Jun 06, 2018 at 08:55

Re: [dpdk-dev] [PATCH] net/mlx5: fix error number handling

2018-06-19 Thread Nélio Laranjeiro
On Mon, Jun 18, 2018 at 05:06:41PM +, Yongseok Koh wrote: > > > On Jun 7, 2018, at 12:39 AM, Nélio Laranjeiro > > wrote: > > > > On Wed, Jun 06, 2018 at 11:39:27AM -0700, Yongseok Koh wrote: > >> On Wed, Jun 06, 2018 at 08:55:01AM +0200, Nélio Laranjeiro wrote: > >>> On Tue, Jun 05, 2018 at

Re: [dpdk-dev] [PATCH] net/mlx5: fix error number handling

2018-06-18 Thread Yongseok Koh
> On Jun 7, 2018, at 12:39 AM, Nélio Laranjeiro > wrote: > > On Wed, Jun 06, 2018 at 11:39:27AM -0700, Yongseok Koh wrote: >> On Wed, Jun 06, 2018 at 08:55:01AM +0200, Nélio Laranjeiro wrote: >>> On Tue, Jun 05, 2018 at 09:36:32PM +, Yongseok Koh wrote: > On Jun 4, 2018, at 11:52 PM, Né

Re: [dpdk-dev] [PATCH] net/mlx5: fix error number handling

2018-06-07 Thread Nélio Laranjeiro
On Wed, Jun 06, 2018 at 11:39:27AM -0700, Yongseok Koh wrote: > On Wed, Jun 06, 2018 at 08:55:01AM +0200, Nélio Laranjeiro wrote: > > On Tue, Jun 05, 2018 at 09:36:32PM +, Yongseok Koh wrote: > > > > On Jun 4, 2018, at 11:52 PM, Nélio Laranjeiro > > > > wrote: > > > > > > > > On Mon, Jun 04,

Re: [dpdk-dev] [PATCH] net/mlx5: fix error number handling

2018-06-06 Thread Yongseok Koh
On Wed, Jun 06, 2018 at 08:55:01AM +0200, Nélio Laranjeiro wrote: > On Tue, Jun 05, 2018 at 09:36:32PM +, Yongseok Koh wrote: > > > On Jun 4, 2018, at 11:52 PM, Nélio Laranjeiro > > > wrote: > > > > > > On Mon, Jun 04, 2018 at 10:37:31AM -0700, Yongseok Koh wrote: > > >> rte_errno should be

Re: [dpdk-dev] [PATCH] net/mlx5: fix error number handling

2018-06-06 Thread Nélio Laranjeiro
On Tue, Jun 05, 2018 at 09:36:32PM +, Yongseok Koh wrote: > > On Jun 4, 2018, at 11:52 PM, Nélio Laranjeiro > > wrote: > > > > On Mon, Jun 04, 2018 at 10:37:31AM -0700, Yongseok Koh wrote: > >> rte_errno should be saved only if error has occurred because rte_errno > >> could have garbage val

Re: [dpdk-dev] [PATCH] net/mlx5: fix error number handling

2018-06-05 Thread Yongseok Koh
> On Jun 4, 2018, at 11:52 PM, Nélio Laranjeiro > wrote: > > On Mon, Jun 04, 2018 at 10:37:31AM -0700, Yongseok Koh wrote: >> rte_errno should be saved only if error has occurred because rte_errno >> could have garbage value. >> >> Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno v

Re: [dpdk-dev] [PATCH] net/mlx5: fix error number handling

2018-06-04 Thread Nélio Laranjeiro
On Mon, Jun 04, 2018 at 10:37:31AM -0700, Yongseok Koh wrote: > rte_errno should be saved only if error has occurred because rte_errno > could have garbage value. > > Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") > Cc: sta...@dpdk.org > > Signed-off-by: Yongseok Koh > --

[dpdk-dev] [PATCH] net/mlx5: fix error number handling

2018-06-04 Thread Yongseok Koh
rte_errno should be saved only if error has occurred because rte_errno could have garbage value. Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 de