Re: [dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro

2020-02-11 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Sunday, February 9, 2020 11:17 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro > &g

Re: [dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro

2020-02-10 Thread Matan Azrad
From: Thomas Monjalon > 10/02/2020 09:52, Thomas Monjalon: > > 10/02/2020 07:32, Matan Azrad: > > > From: Thomas Monjalon > > > > > > > Replace checking against 65535 limit, with a simpler form using > > > > RTE_MIN and UINT16_MAX macros. > > > > > > > > Signed-off-by: Thomas Monjalon > > > > -

Re: [dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro

2020-02-10 Thread Thomas Monjalon
10/02/2020 09:52, Thomas Monjalon: > 10/02/2020 07:32, Matan Azrad: > > From: Thomas Monjalon > > > > > Replace checking against 65535 limit, > > > with a simpler form using RTE_MIN and UINT16_MAX macros. > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > > > No more misusing of *_MAX \ R

Re: [dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro

2020-02-10 Thread Thomas Monjalon
10/02/2020 07:32, Matan Azrad: > From: Thomas Monjalon > > > Replace checking against 65535 limit, > > with a simpler form using RTE_MIN and UINT16_MAX macros. > > > > Signed-off-by: Thomas Monjalon > > --- > > No more misusing of *_MAX \ RTE_MIN\RTE_MAX in the mlx PMDs? Sorry I don't understa

Re: [dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro

2020-02-09 Thread Matan Azrad
Hi Thomas From: Thomas Monjalon > Sent: Sunday, February 9, 2020 11:17 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx: replace hardcoded value with macro > > Replace checking against 65535 limit, > with a simpler form using RTE_MIN and UI

[dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro

2020-02-09 Thread Thomas Monjalon
Replace checking against 65535 limit, with a simpler form using RTE_MIN and UINT16_MAX macros. Signed-off-by: Thomas Monjalon --- drivers/net/mlx4/mlx4_ethdev.c | 5 ++--- drivers/net/mlx5/mlx5_ethdev.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx4/ml