Re: [dpdk-dev] [PATCH] net/kni: fix crash caused by double stop

2019-11-26 Thread Wang, Yinan
Test-by :Wang, Yinan > -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: 2019年11月26日 22:47 > To: Yigit, Ferruh > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/kni: fix crash caused by double stop > > On 11/26/2019 10:50 AM, Ferruh

Re: [dpdk-dev] [PATCH] net/kni: fix crash caused by double stop

2019-11-26 Thread Ferruh Yigit
On 11/26/2019 10:50 AM, Ferruh Yigit wrote: > 'close()' calls 'stop()' and 'stop()' cancels pthread without any check. > Calling 'stop()' & 'close()' sequentially tries to cancel pthread twice > which will cause a crash. > > Adding a state check in 'stop()' before canceling the pthread to prevent

[dpdk-dev] [PATCH] net/kni: fix crash caused by double stop

2019-11-26 Thread Ferruh Yigit
'close()' calls 'stop()' and 'stop()' cancels pthread without any check. Calling 'stop()' & 'close()' sequentially tries to cancel pthread twice which will cause a crash. Adding a state check in 'stop()' before canceling the pthread to prevent multiple stop. Fixes: 696fbc7bb4fc ("net/kni: remove

Re: [dpdk-dev] [PATCH] net/kni: fix crash

2017-04-18 Thread Ferruh Yigit
On 4/18/2017 3:00 PM, Ferruh Yigit wrote: > eth_dev->device is now NULL, and accessing eth_dev->device->driver > crashes. > No need to set this value, removed completely. > > Fixes: 5d2aa461cbca ("vdev: use generic vdev struct for probe and remove") > > Signed-off-by: Ferruh Yigit Applied to dp

[dpdk-dev] [PATCH] net/kni: fix crash

2017-04-18 Thread Ferruh Yigit
eth_dev->device is now NULL, and accessing eth_dev->device->driver crashes. No need to set this value, removed completely. Fixes: 5d2aa461cbca ("vdev: use generic vdev struct for probe and remove") Signed-off-by: Ferruh Yigit --- drivers/net/kni/rte_eth_kni.c | 1 - 1 file changed, 1 deletion(-