Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-08-13 Thread Ferruh Yigit
On 8/12/2018 9:46 AM, Shahaf Shuler wrote: > Sunday, August 12, 2018 10:53 AM, Andrew Rybchenko: >> Subject: Re: [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from >> ixgbe >> >> On 12.08.2018 09:28, Shahaf Shuler wrote: >>> Thursday, August 9, 2018 11:32 AM, Ferruh Yigit: Subject: Re:

Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-08-12 Thread Shahaf Shuler
Sunday, August 12, 2018 10:53 AM, Andrew Rybchenko: > Subject: Re: [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from > ixgbe > > On 12.08.2018 09:28, Shahaf Shuler wrote: > > Thursday, August 9, 2018 11:32 AM, Ferruh Yigit: > >> Subject: Re: [PATCH] net/ixgbe: remove hardcoded CRC STRIP co

Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-08-12 Thread Andrew Rybchenko
On 12.08.2018 09:28, Shahaf Shuler wrote: Thursday, August 9, 2018 11:32 AM, Ferruh Yigit: Subject: Re: [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe On 7/24/2018 3:36 AM, Wei Zhao wrote: There is CRC related ifdefs for ixgbe: CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n It

Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-08-11 Thread Shahaf Shuler
Thursday, August 9, 2018 11:32 AM, Ferruh Yigit: > Subject: Re: [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from > ixgbe > > On 7/24/2018 3:36 AM, Wei Zhao wrote: > > There is CRC related ifdefs for ixgbe: > > CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n > > It is used in VF drivers ixg

Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-08-09 Thread Ferruh Yigit
On 7/24/2018 3:36 AM, Wei Zhao wrote: > There is CRC related ifdefs for ixgbe: > CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n > It is used in VF drivers ixgbevf_dev_configure() functions. > VF cannot change the CRC strip behavior and based on what PF > configured it needs to response proper to us

Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-08-08 Thread Zhao1, Wei
: Yigit, Ferruh ; sta...@dpdk.org; Zhao1, > > Wei ; Lu, Wenzhuo > > Subject: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP > > config from ixgbe > > > > There is CRC related ifdefs for ixgbe: > > CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n > > It is us

Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-08-01 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Tuesday, July 24, 2018 10:37 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; sta...@dpdk.org; Zhao1, Wei > ; Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/ixgbe: remove hardc

[dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-07-23 Thread Wei Zhao
There is CRC related ifdefs for ixgbe: CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n It is used in VF drivers ixgbevf_dev_configure() functions. VF cannot change the CRC strip behavior and based on what PF configured it needs to response proper to user ixgbevf_dev_configure() request. Right now wh