Re: [dpdk-dev] [PATCH] net/ixgbe: fix macsec setting

2019-10-28 Thread Ye Xiaolong
Hi, Guinan Overall the fix looks good to me, a few comments inline. On 10/25, Sun GuinanX wrote: >macsec setting is not valid when port is stopped. >In order to make it valid, the patch changes the setting >to where port is started. > >Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads

[dpdk-dev] [PATCH] net/ixgbe: fix macsec setting

2019-10-24 Thread Sun GuinanX
macsec setting is not valid when port is stopped. In order to make it valid, the patch changes the setting to where port is started. Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Sun GuinanX --- drivers/net/ixgbe/ixgbe_ethdev.c | 160 +++