Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset

2020-04-22 Thread Ye Xiaolong
On 04/13, Shougang Wang wrote: >It's a normal behavior to change the link status to up after >resetting the port. So it is unnecessary to set link down before >starting port, and changing the link state(link up/down) frequently >will cause link speed unstable. > >Fixes: c3f2fbff78cf ("net/ixgbe: fi

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset

2020-04-20 Thread Wang, ShougangX
Hi, Xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, April 14, 2020 3:54 PM > To: Wang, ShougangX > Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset >

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset

2020-04-14 Thread Ye Xiaolong
Hi, Shougang On 04/13, Shougang Wang wrote: >It's a normal behavior to change the link status to up after >resetting the port. So it is unnecessary to set link down before >starting port, and changing the link state(link up/down) frequently >will cause link speed unstable. > >Fixes: c3f2fbff78cf (

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset

2020-04-13 Thread Zhang, XuemingX
Tested-by: Zhang, XuemingX >-Original Message- >From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shougang Wang >Sent: Monday, April 13, 2020 9:39 AM >To: dev@dpdk.org >Cc: Lu, Wenzhuo ; Yang, Qiming >; Wang, ShougangX ; >sta...@dpdk.org >Subject: [dpdk-dev

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset

2020-04-12 Thread Yang, Qiming
> -Original Message- > From: Wang, ShougangX > Sent: Monday, April 13, 2020 09:39 > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Wang, ShougangX ; > sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix link status after port reset > > It's a normal behavior to change the link sta

[dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset

2020-04-12 Thread Shougang Wang
It's a normal behavior to change the link status to up after resetting the port. So it is unnecessary to set link down before starting port, and changing the link state(link up/down) frequently will cause link speed unstable. Fixes: c3f2fbff78cf ("net/ixgbe: fix link status") Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status inconsistencies

2020-03-28 Thread Ye Xiaolong
On 02/26, taox@intel.com wrote: >From: Zhu Tao > >Setting LINK UP or LINK DOWN is divided into two parts, with >the main task done in a separate thread, which can take up >to 9 seconds. If cancel the thread in execution, may cause state >inconsistencies. Therefore, must wait for the previous s

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status inconsistencies

2020-03-18 Thread Zhu, TaoX
+Jiang Yu BR, Zhu, Tao > -Original Message- > From: Zhu, TaoX > Sent: Tuesday, March 3, 2020 10:00 AM > To: Ananyev, Konstantin ; Lu, Wenzhuo > ; Ye, Xiaolong > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/ixgbe: fix link status inconsistencies > > +Xiaolong > > BR, >

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status inconsistencies

2020-03-02 Thread Zhu, TaoX
+Xiaolong BR, Zhu, Tao > -Original Message- > From: Zhu, TaoX > Sent: Wednesday, February 26, 2020 8:07 PM > To: Ananyev, Konstantin ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhu, TaoX ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix link status inconsistencies > > From: Zhu Tao > > Sett

[dpdk-dev] [PATCH] net/ixgbe: fix link status inconsistencies

2020-02-26 Thread taox . zhu
From: Zhu Tao Setting LINK UP or LINK DOWN is divided into two parts, with the main task done in a separate thread, which can take up to 9 seconds. If cancel the thread in execution, may cause state inconsistencies. Therefore, must wait for the previous setting to exit normally before setting the

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status

2019-11-12 Thread Ye Xiaolong
On 11/13, Cui LunyuanX wrote: >After ports reset, tx laser register will be reset. The link >status for 82599eb got from link status register was not correct. >Set tx laser disable after ports reset. > >Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update") >Cc: sta...@dpdk.org

[dpdk-dev] [PATCH] net/ixgbe: fix link status

2019-11-12 Thread Cui LunyuanX
After ports reset, tx laser register will be reset. The link status for 82599eb got from link status register was not correct. Set tx laser disable after ports reset. Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update") Cc: sta...@dpdk.org Signed-off-by: Lunyuan Cui --- d

[dpdk-dev] [PATCH] net/ixgbe: fix link status when link is NACK

2018-07-22 Thread Yanglong Wu
Link status should be set as down when link is NACK. Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF") Signed-off-by: Yanglong Wu --- drivers/net/ixgbe/ixgbe_ethdev.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/