Re: [dpdk-dev] [PATCH] net/ixgbe: fix TDH register setting issue

2018-11-19 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Monday, November 19, 2018 6:12 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Wu, Jingjing ; Byrne, Stephen1 > > Subject: RE: [PATCH] net/ixgbe: fix TDH register setting issue > > Hi, qi > I don't understand why dose this patch not change re

Re: [dpdk-dev] [PATCH] net/ixgbe: fix TDH register setting issue

2018-11-19 Thread Wu, Yanglong
Hi, qi I don't understand why dose this patch not change register write order. THD is write before TXDCTL.ENABL. The Intel 82599 data sheet (https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/82599-10-gbe-controller-datasheet.pdf, ยง8.2.3.9.8) states that "The only time t

Re: [dpdk-dev] [PATCH] net/ixgbe: fix TDH register setting issue

2018-11-16 Thread Zhang, Qi Z
Hi Yanglong: > -Original Message- > From: Wu, Yanglong > Sent: Thursday, November 15, 2018 6:32 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wu, Jingjing ; > Byrne, Stephen1 ; Wu, Yanglong > > Subject: [PATCH] net/ixgbe: fix TDH register setting issue > > The only time that software should

[dpdk-dev] [PATCH] net/ixgbe: fix TDH register setting issue

2018-11-15 Thread Yanglong Wu
The only time that software should write to the TDH register is after a reset (hardware reset or CTRL.RST) and before enabling the transmit function (TXDCTL.ENABLE). If software were to write to this register while the transmit function was enabled, the on-chip descriptor buffers might be invalidat