Re: [dpdk-dev] [PATCH] net/igc: fix memory illegal accesses

2020-05-07 Thread Zhang, AlvinX
Hi Jia, First of all, this is a coverity issue, and it's really a false positives. But do some macro checking will improve code robustness. Thanks, Alvin > -Original Message- > From: Guo, Jia > Sent: Thursday, May 7, 2020 2:30 PM > To: Zhang, AlvinX ; dev@dpdk.org > Cc: Zhao1, Wei ; Ye,

Re: [dpdk-dev] [PATCH] net/igc: fix memory illegal accesses

2020-05-06 Thread Jeff Guo
hi, alvin On 5/7/2020 10:01 AM, alvinx.zh...@intel.com wrote: From: Alvin Zhang Add memory access out-of-bounds check. Could you explain why add ...?  If not add, what issue? Fixes: bd3fcf0d0fa1 (net/igc: support RSS) Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/i

[dpdk-dev] [PATCH] net/igc: fix memory illegal accesses

2020-05-06 Thread alvinx . zhang
From: Alvin Zhang Add memory access out-of-bounds check. Fixes: bd3fcf0d0fa1 (net/igc: support RSS) Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/igc/igc_ethdev.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/igc/igc_ethdev.c b/