Re: [dpdk-dev] [PATCH] net/i40evf: regression fix - reenable interrupts in handler

2018-04-10 Thread Jankowski, Konrad
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, April 10, 2018 2:26 PM > To: Jankowski, Konrad ; Dai, Wei > ; Xing, Beilei ; Wu, Jingjing > ; dev@dpdk.org > Subject: RE: [PATCH] net/i40evf: regression fix - reenable interrupts in > handler > > Hi Konrad: > Sorry fo

Re: [dpdk-dev] [PATCH] net/i40evf: regression fix - reenable interrupts in handler

2018-04-10 Thread Zhang, Qi Z
Hi Konrad: Sorry for late reply. > -Original Message- > From: Jankowski, Konrad > Sent: Thursday, April 5, 2018 1:12 AM > To: Zhang, Qi Z ; Dai, Wei ; Xing, > Beilei ; Wu, Jingjing ; > dev@dpdk.org > Subject: RE: [PATCH] net/i40evf: regression fix - reenable interrupts in > handle

Re: [dpdk-dev] [PATCH] net/i40evf: regression fix - reenable interrupts in handler

2018-04-06 Thread Zhang, Helin
> > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jankowski, Konrad > > Sent: Thursday, April 5, 2018 1:12 AM > > To: Zhang, Qi Z; Dai, Wei; Xing, Beilei; Wu, Jingjing; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] net

Re: [dpdk-dev] [PATCH] net/i40evf: regression fix - reenable interrupts in handler

2018-04-06 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jankowski, Konrad > Sent: Thursday, April 5, 2018 1:12 AM > To: Zhang, Qi Z; Dai, Wei; Xing, Beilei; Wu, Jingjing; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40evf: regression

Re: [dpdk-dev] [PATCH] net/i40evf: regression fix - reenable interrupts in handler

2018-04-05 Thread Jankowski, Konrad
Hi Zhang, If you look at the source of interrupt handlers in both the igb_uio and uio_pci_generic drivers (look for irqreturn_t type), you will see they can disable interrupts immediately after receipt of one. It's up to the user to make sure they're re-enabled. Also please compare with code in

Re: [dpdk-dev] [PATCH] net/i40evf: regression fix - reenable interrupts in handler

2018-03-27 Thread Zhang, Qi Z
Hi Jankowski: > -Original Message- > From: Jankowski, KonradX > Sent: Thursday, February 15, 2018 2:33 AM > To: Dai, Wei ; Xing, Beilei ; Zhang, > Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Cc: Jankowski, KonradX > Subject: [PATCH] net/i40evf: regression fix - reenable interrupts in handler >

[dpdk-dev] [PATCH] net/i40evf: regression fix - reenable interrupts in handler

2018-02-14 Thread Konrad Jankowski
Commit 66b8304f removed the rte_intr_enable() call from i40evf_dev_interrupt_handler() as a "bonus". On one of my systems this causes the AdminQ messages to stop beeing delivered to the VF. This results in unability to initialize and use the port. With this patch it works again. System in question