Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD

2017-10-10 Thread Roger B. Melton
On 10/10/17 7:39 AM, Bruce Richardson wrote: On Tue, Oct 10, 2017 at 07:05:33AM -0400, Roger B. Melton wrote: Hi Bruce, I can.  It will take a day or 2 to get the results. Regards, Roger Thanks. Keep us posted. We want to ensure we have the best fix possible for the issue in this release.

Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD

2017-10-10 Thread Bruce Richardson
On Tue, Oct 10, 2017 at 07:05:33AM -0400, Roger B. Melton wrote: > Hi Bruce, > > I can.  It will take a day or 2 to get the results. > > Regards, > Roger > Thanks. Keep us posted. We want to ensure we have the best fix possible for the issue in this release. /Bruce > > On 10/10/17 4:48 AM, B

Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD

2017-10-10 Thread Roger B. Melton
Hi Bruce, I can.  It will take a day or 2 to get the results. Regards, Roger On 10/10/17 4:48 AM, Bruce Richardson wrote: +Roger Melton On Tue, Oct 10, 2017 at 09:22:05AM -0400, Qi Zhang wrote: vPMD tx does not set sw_ring's mbuf to NULL after free it. So to prevent same mbuf be free again,

Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD

2017-10-10 Thread Bruce Richardson
+Roger Melton On Tue, Oct 10, 2017 at 09:22:05AM -0400, Qi Zhang wrote: > vPMD tx does not set sw_ring's mbuf to NULL after free it. > So to prevent same mbuf be free again, we need more carefully > check in i40e_tx_queue_release_mbufs. > > Fixes: b4669bb95038 ("i40e: add vector Tx") > Cc: sta...

[dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD

2017-10-09 Thread Qi Zhang
vPMD tx does not set sw_ring's mbuf to NULL after free it. So to prevent same mbuf be free again, we need more carefully check in i40e_tx_queue_release_mbufs. Fixes: b4669bb95038 ("i40e: add vector Tx") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- v2: - fix at i40e_tx_queue_release_mbufs so n

Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD

2017-10-09 Thread Zhang, Qi Z
Hi Konstantin: > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, October 9, 2017 8:44 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf

Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD

2017-10-09 Thread Bruce Richardson
; > > Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org > > Subject: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD > > > > The patch reset tx queue sw_ring's mbuf to NULL after it is free in > > i40_tx_free_bufs, this prevent same mbuf b

Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD

2017-10-09 Thread Ananyev, Konstantin
Hi Zhang, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang > Sent: Monday, October 9, 2017 9:54 AM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix unexp

Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD

2017-10-08 Thread Wu, Jingjing
Hi, qi Is your patch duplicated with this http://www.dpdk.org/dev/patchwork/patch/29814/ ? Thanks Jingjing > -Original Message- > From: Zhang, Qi Z > Sent: Monday, October 9, 2017 4:54 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org > Subject: [PA

[dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD

2017-10-08 Thread Qi Zhang
The patch reset tx queue sw_ring's mbuf to NULL after it is free in i40_tx_free_bufs, this prevent same mbuf be free again in i40e_dev_tx_queue_release. This fix follow the same implemenation of non-vPMD. Fixes: b4669bb95038 ("i40e: add vector Tx") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang ---