Re: [dpdk-dev] [PATCH] net/i40e: fix i40e flow director merge

2020-01-21 Thread Sexton, Rory
Nack - if statement should look like this: else if (pctype == I40E_FILTER_PCTYPE_NONF_IPV4_TCP || pctype == I40E_FILTER_PCTYPE_NONF_IPV4_UDP || pctype == I40E_FILTER_PCTYPE_NONF_IPV4_SCTP || pctype == I40E_FILTER_PCTYPE_NONF_IPV4_OTHER ||

Re: [dpdk-dev] [PATCH] net/i40e: fix i40e flow director merge

2020-01-21 Thread Iremonger, Bernard
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, January 21, 2020 4:02 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Yigit, Ferruh ; Sexton, Rory > > Cc: Iremonger, Bernard > Subject: [PATCH] net/i40e: fix i40e flow director merge > > Merge of i40e_fdir.c adde

[dpdk-dev] [PATCH] net/i40e: fix i40e flow director merge

2020-01-21 Thread Bernard Iremonger
Merge of i40e_fdir.c added checks on cus_pctype->index which are not necessary and caused flow creation for ESP to fail. Removed the added lines to fix the issue. Fixes: c5f8365bc85d ("net/i40e: support flow director for L2TPv3 over IP") Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40