Re: [dpdk-dev] [PATCH] net/i40e: fix counters

2020-12-23 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Igor Ryzhov > Sent: Tuesday, November 17, 2020 4:57 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix counters > > When low and high registers are read separately, this

Re: [dpdk-dev] [PATCH] net/i40e: fix counters

2020-11-24 Thread Igor Ryzhov
Original Message- > > From: dev On Behalf Of Thomas Monjalon > > Sent: Tuesday, November 24, 2020 4:25 PM > > To: Igor Ryzhov ; dev ; Guo, Jia > > > > Cc: dpdk stable ; Xing, Beilei ; > Yigit, > > Ferruh > > Subject: Re: [dpdk-dev] [PATCH] net/i40e:

Re: [dpdk-dev] [PATCH] net/i40e: fix counters

2020-11-24 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Tuesday, November 24, 2020 4:25 PM > To: Igor Ryzhov ; dev ; Guo, Jia > > Cc: dpdk stable ; Xing, Beilei ; > Yigit, > Ferruh > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix coun

Re: [dpdk-dev] [PATCH] net/i40e: fix counters

2020-11-24 Thread Thomas Monjalon
I will follow the recommendation of Ferruh and i40e maintainers. It is risky but it can be applied just before the release. 24/11/2020 04:34, Guo, Jia: > hi, igor ryzhov and Thomas > > Since this remain issue is report recently and we need to reproduce the issue > and evaluate the patch and gua

Re: [dpdk-dev] [PATCH] net/i40e: fix counters

2020-11-23 Thread Guo, Jia
hi, igor ryzhov and Thomas Since this remain issue is report recently and we need to reproduce the issue and evaluate the patch and guaranty no side affect for other case, so I am not sure even I don't think it still have time window to hit 20.11. But whatever we have begin to check your patch f

Re: [dpdk-dev] [PATCH] net/i40e: fix counters

2020-11-19 Thread Igor Ryzhov
CC maintainers and Thomas. This fix should be 20.11. The issue is seen multiple times a day under ~20G traffic with stats collection once per second. Igor On Tue, Nov 17, 2020 at 11:56 AM Igor Ryzhov wrote: > When low and high registers are read separately, this opens the door to > a race cond

[dpdk-dev] [PATCH] net/i40e: fix counters

2020-11-17 Thread Igor Ryzhov
When low and high registers are read separately, this opens the door to a race condition: - low register is read - NIC updates the registers - high register is read Because of this, we may end up with an incorrect counter value. Let's read the registers in one shot, as it is done in Linux kernel s