Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR check programming status error

2018-07-12 Thread Zhao1, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, July 13, 2018 11:16 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/i40e: fix FDIR check programming status error > > > > > -Original Message- > > From: Zhao1, Wei > > Sent: Friday, Ju

Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR check programming status error

2018-07-12 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, July 13, 2018 11:12 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/i40e: fix FDIR check programming status error > > This code change is ok also, I don't think so, with your change, it will

Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR check programming status error

2018-07-12 Thread Zhao1, Wei
This code change is ok also, but it seems need to add more Judging branch? IF you think it is almost the same, I WILL commit a new v2. > -Original Message- > From: Zhang, Qi Z > Sent: Friday, July 13, 2018 11:06 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PAT

Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR check programming status error

2018-07-12 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, July 11, 2018 4:25 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; sta...@dpdk.org; Zhao1, Wei > > Subject: [PATCH] net/i40e: fix FDIR check programming status error > > In i40e FDIR PMD code for checking programming status function

[dpdk-dev] [PATCH] net/i40e: fix FDIR check programming status error

2018-07-11 Thread Wei Zhao
In i40e FDIR PMD code for checking programming status function i40e_check_fdir_programming_status(), the initial value of return value ret should be set to -1 not 0, because if DD bit of I40E_RX_DESC_STATUS_DD is not write back, this function will return 0 to upper function, this give an error info