[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

2016-07-22 Thread Thomas Monjalon
2016-07-21 16:24, Xiao Wang: > Sometimes app just wants to update the RSS hash function and no RSS key > update is needed, but fm10k pmd will return EINVAL for this case. > > If the rss_key is NULL, we don't need to check the rss_key_len. > > Fixes: 57033cdf8fdc ("fm10k: add PF RSS") > > Reporte

[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

2016-07-22 Thread Thomas Monjalon
2016-07-22 08:23, Chen, Jing D: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-07-21 09:35, Wang, Xiao W: > > > From: Chen, Jing D > > > > > --- a/drivers/net/fm10k/fm10k_ethdev.c > > > > > +++ b/drivers/net/fm10k/fm10k_ethdev.c > > > > > @@ -2159,8 +2159,8 @@ fm10k_rss_hash

[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

2016-07-22 Thread Thomas Monjalon
2016-07-21 09:35, Wang, Xiao W: > From: Chen, Jing D > > > --- a/drivers/net/fm10k/fm10k_ethdev.c > > > +++ b/drivers/net/fm10k/fm10k_ethdev.c > > > @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev, > > > > > > PMD_INIT_FUNC_TRACE(); > > > > > > - if (rss_conf->rss_key_len < FM

[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

2016-07-22 Thread Chen, Jing D
Hi, Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, July 22, 2016 4:29 PM > To: Chen, Jing D > Cc: dev at dpdk.org; Wang, Xiao W ; Lin, Xueqin > > Subject: Re: [dpdk-dev] [PATCH] net/fm10k: fix RSS hash c

[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

2016-07-22 Thread Chen, Jing D
Hi, Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, July 22, 2016 4:22 PM > To: Chen, Jing D > Cc: dev at dpdk.org; Wang, Xiao W ; Lin, Xueqin > > Subject: Re: [dpdk-dev] [PATCH] net/fm10k: fix RSS hash conf

[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

2016-07-21 Thread Xiao Wang
Sometimes app just wants to update the RSS hash function and no RSS key update is needed, but fm10k pmd will return EINVAL for this case. If the rss_key is NULL, we don't need to check the rss_key_len. Fixes: 57033cdf8fdc ("fm10k: add PF RSS") Reported-by: Xueqin Lin Signed-off-by: Xiao Wang -

[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

2016-07-21 Thread Wang, Xiao W
Hi Mark, > -Original Message- > From: Chen, Jing D > Sent: Thursday, July 21, 2016 4:48 PM > To: Wang, Xiao W ; dev at dpdk.org > Cc: Lin, Xueqin > Subject: RE: [PATCH] net/fm10k: fix RSS hash config > > Hi, > > > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > > b/drivers/net/fm10k/fm1

[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

2016-07-21 Thread Chen, Jing D
Hi, > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > b/drivers/net/fm10k/fm10k_ethdev.c > index 144b2de..01f4a72 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev, > > PMD_INIT_FUN