Re: [dpdk-dev] [PATCH] net/failsafe: improve stats accuracy

2017-10-16 Thread Matan Azrad
Hi Geatan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Monday, October 16, 2017 11:28 AM > To: Matan Azrad > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/failsafe: improve stats accuracy > > Hey Matan, > > Thanks for the patch. Here are some remarks: >

Re: [dpdk-dev] [PATCH] net/failsafe: improve stats accuracy

2017-10-16 Thread Gaëtan Rivet
Hey Matan, Thanks for the patch. Here are some remarks: On Mon, Oct 16, 2017 at 07:41:50AM +, Matan Azrad wrote: > The stats_get API was changed to return error in case of failure at > stats getting process time. > By this way, failsafe can get stats snapshot in removal process for > each PMD

[dpdk-dev] [PATCH] net/failsafe: improve stats accuracy

2017-10-16 Thread Matan Azrad
The stats_get API was changed to return error in case of failure at stats getting process time. By this way, failsafe can get stats snapshot in removal process for each PMD which can give stats after removal event. This patch implements ultimate stats snapshot on removal time by trying to get the