Re: [dpdk-dev] [PATCH] net/failsafe: fix tx sub device deactivating

2017-08-16 Thread Gaëtan Rivet
On Wed, Aug 16, 2017 at 09:02:31AM +, Matan Azrad wrote: > Hi Gaetan > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Wednesday, August 16, 2017 11:47 AM > > To: Matan Azrad > > Cc: dev@dpdk.org; sta...@dpdk.org > > Subject: Re: [PATCH] net/fai

Re: [dpdk-dev] [PATCH] net/failsafe: fix tx sub device deactivating

2017-08-16 Thread Matan Azrad
Hi Gaetan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, August 16, 2017 11:47 AM > To: Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] net/failsafe: fix tx sub device deactivating > > Hi Matan, > > Thanks for spotting

Re: [dpdk-dev] [PATCH] net/failsafe: fix tx sub device deactivating

2017-08-16 Thread Gaëtan Rivet
Hi Matan, Thanks for spotting this, a few nits below. On Tue, Aug 15, 2017 at 09:59:19AM +0300, Matan Azrad wrote: > The corrupted code couldn't recognize that all sub devices > were not ready for tx traffic when failsafe PMD was trying > to switch device because of an unreachable condition using

[dpdk-dev] [PATCH] net/failsafe: fix tx sub device deactivating

2017-08-15 Thread Matan Azrad
The corrupted code couldn't recognize that all sub devices were not ready for tx traffic when failsafe PMD was trying to switch device because of an unreachable condition using. Hence, the current tx sub device variable was not updated correctly. The fix removed the unreachable condition and adds