Re: [dpdk-dev] [PATCH] net/failsafe: fix for missing pclose after popen

03/08/2017 15:58, Gaëtan Rivet: > Hi Raslan, > > I sent a patch earlier regarding this but we will use yours. > Two small nits below. > > On Thu, Aug 03, 2017 at 04:09:58PM +0300, rasl...@mellanox.com wrote: > > From: Raslan Darawsheh > > > > When there is no prefered device, failsafe will alwa

Re: [dpdk-dev] [PATCH] net/failsafe: fix for missing pclose after popen

Hi Raslan, I sent a patch earlier regarding this but we will use yours. Two small nits below. On Thu, Aug 03, 2017 at 04:09:58PM +0300, rasl...@mellanox.com wrote: > From: Raslan Darawsheh > > When there is no prefered device, failsafe will always > try to scan for prefered device. And if there

[dpdk-dev] [PATCH] net/failsafe: fix for missing pclose after popen

From: Raslan Darawsheh When there is no prefered device, failsafe will always try to scan for prefered device. And if there is no device found with the exec option, popen() will get an empty output. In this case, it was forgotten to close the file descriptor.o it is fixed by closing the file desc