Re: [dpdk-dev] [PATCH] net/failsafe: fix exec parameter parsing error flow

2017-08-30 Thread Matan Azrad
Hi Gaetan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, August 30, 2017 5:25 PM > To: Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: Re: [PATCH] net/failsafe: fix exec parameter parsing error flow > > On Wed,

Re: [dpdk-dev] [PATCH] net/failsafe: fix exec parameter parsing error flow

2017-08-30 Thread Gaëtan Rivet
On Wed, Aug 30, 2017 at 06:11:47AM +, Matan Azrad wrote: > Hi Gaetan > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Tuesday, August 29, 2017 7:34 PM > > To: Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; > > sta...@dpdk.org > > Subject:

Re: [dpdk-dev] [PATCH] net/failsafe: fix exec parameter parsing error flow

2017-08-29 Thread Matan Azrad
Hi Gaetan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Tuesday, August 29, 2017 7:34 PM > To: Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: Re: [PATCH] net/failsafe: fix exec parameter parsing error flow > > Hi Matan,

Re: [dpdk-dev] [PATCH] net/failsafe: fix exec parameter parsing error flow

2017-08-29 Thread Gaëtan Rivet
Hi Matan, On Tue, Aug 29, 2017 at 05:59:08PM +0300, Matan Azrad wrote: > The corrupted code returns success value in case of the > execution process output stream is empty(EOF). > It causes to segmentation fault while failsafe polls > this command line again, than gets success and tries to > do ho

[dpdk-dev] [PATCH] net/failsafe: fix exec parameter parsing error flow

2017-08-29 Thread Matan Azrad
The corrupted code returns success value in case of the execution process output stream is empty(EOF). It causes to segmentation fault while failsafe polls this command line again, than gets success and tries to do hotplug add to the sub device by uninitialized pointer dereferencing. Morever, when