Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread John Daley (johndale)
> -Original Message- > From: Stephen Hemminger > Sent: Friday, July 26, 2019 1:51 PM > To: Hyong Youb Kim (hyonkim) > Cc: John Daley (johndale) ; Ferruh Yigit > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging > > O

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread Stephen Hemminger
On Fri, 26 Jul 2019 04:21:23 + "Hyong Youb Kim (hyonkim)" wrote: > > -Original Message- > > From: John Daley (johndale) > > Sent: Friday, July 26, 2019 5:26 AM > > To: Ferruh Yigit > > Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim) > > Subject: RE: [PATCH] net/enic: retain previous mess

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread John Daley (johndale)
> -Original Message- > From: Ferruh Yigit > Sent: Friday, July 26, 2019 3:01 AM > To: John Daley (johndale) > Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim) > Subject: Re: [PATCH] net/enic: retain previous message logging > > On 7/26/2019 9:17 AM, John Daley (johndale) wrote: > > Actually

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 9:17 AM, John Daley (johndale) wrote: > Actually, after talking to a couple internal folks, we'd like to get the > patch in if possible- many of our customer issues are due to the wrong number > of queues, etc, which are reported in the default logs. To ask them to add > --log-level

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 5:21 AM, Hyong Youb Kim (hyonkim) wrote: >> -Original Message- >> From: John Daley (johndale) >> Sent: Friday, July 26, 2019 5:26 AM >> To: Ferruh Yigit >> Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim) >> Subject: RE: [PATCH] net/enic: retain previous message logging >> >> Ok, l

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread John Daley (johndale)
Actually, after talking to a couple internal folks, we'd like to get the patch in if possible- many of our customer issues are due to the wrong number of queues, etc, which are reported in the default logs. To ask them to add --log-level=enic,info would be a pain, esp. for apps like OVS, fd.io.

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-25 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: John Daley (johndale) > Sent: Friday, July 26, 2019 5:26 AM > To: Ferruh Yigit > Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim) > Subject: RE: [PATCH] net/enic: retain previous message logging > > Ok, lets NAK this patch. See comment inline. > Thanks, > John > [

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-25 Thread John Daley (johndale)
Ok, lets NAK this patch. See comment inline. Thanks, John > -Original Message- > From: Ferruh Yigit > Sent: Thursday, July 25, 2019 3:07 AM > To: John Daley (johndale) > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/enic: retain previous message logging > > On 7/25/2019 3:46 AM, John Dale

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-25 Thread Ferruh Yigit
On 7/25/2019 3:46 AM, John Daley wrote: > Prior to fix, RTE_LOGTYPE_INFO messages would display in testpmd by > default. After the fix, using dynamic logging, only NOTICE level and > higher were displayed by default and INFO level were not. Change the > messages to NOTICE level so they continue to

[dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-24 Thread John Daley
Prior to fix, RTE_LOGTYPE_INFO messages would display in testpmd by default. After the fix, using dynamic logging, only NOTICE level and higher were displayed by default and INFO level were not. Change the messages to NOTICE level so they continue to display. DTS uses testpmd and parses messages a