Re: [dpdk-dev] [PATCH] net/e1000 igb: fix compile issue with log register

2018-05-21 Thread Zhang, Helin
> -Original Message- > From: Varghese, Vipin > Sent: Monday, May 21, 2018 6:10 PM > To: Van Haaren, Harry; dev@dpdk.org > Cc: Lu, Wenzhuo; Zhang, Helin > Subject: RE: [PATCH] net/e1000 igb: fix compile issue with log register > > > > -Original Message- > > From: Van Haaren, Harr

Re: [dpdk-dev] [PATCH] net/e1000 igb: fix compile issue with log register

2018-05-21 Thread Varghese, Vipin
Acked-by: Vipin Varghese > -Original Message- > From: Van Haaren, Harry > Sent: Monday, May 21, 2018 3:02 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Varghese, Vipin > ; Lu, Wenzhuo ; Zhang, > Helin > Subject: [PATCH] net/e1000 igb: fix compile issue with log register > > This commi

[dpdk-dev] [PATCH] net/e1000 igb: fix compile issue with log register

2018-05-21 Thread Harry van Haaren
This commit fixes a compilation error if EM_PMD is not defined, bug IGB_PMD is. The root cause of the issue was that log init variables are declared as extern in a header file, while the definition of the variables was in e1000_ethdev.c. Hence, the definitions were not available if the e1000 PMD is