Re: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set

2018-10-10 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, October 10, 2018 12:25 AM > To: Luca Boccassi ; dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org; Zhang, Qi Z > ; 3ch...@gmail.com > Subject: RE: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en i

Re: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set

2018-10-10 Thread Zhao1, Wei
: Saturday, July 28, 2018 1:26 AM > > > To: dev@dpdk.org > > > Cc: Lu, Wenzhuo ; Luca Boccassi > > > ; sta...@dpdk.org > > > Subject: [dpdk-dev] [PATCH] net/e1000: do not error out if > > > rx_drop_en is set > > > > > > rx_drop_en is an

Re: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set

2018-10-08 Thread Luca Boccassi
u, Wenzhuo ; Luca Boccassi > > ; sta...@dpdk.org > > Subject: [dpdk-dev] [PATCH] net/e1000: do not error out if > > rx_drop_en is set > > > > rx_drop_en is an optimization that does nothing on single-queue > > devices like > > e1000. Do not force applications th

Re: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set

2018-10-08 Thread Zhao1, Wei
Add Qi for discussion. > -Original Message- > From: Zhao1, Wei > Sent: Monday, October 8, 2018 4:43 PM > To: 'Luca Boccassi' ; dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is &

Re: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set

2018-10-08 Thread Zhao1, Wei
Hi, Luca Boccassi > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Luca Boccassi > Sent: Saturday, July 28, 2018 1:26 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Luca Boccassi > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/e1000

Re: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set

2018-09-26 Thread Luca Boccassi
On Fri, 2018-07-27 at 18:26 +0100, Luca Boccassi wrote: > rx_drop_en is an optimization that does nothing on single-queue > devices like e1000. Do not force applications that do not care to > select per-devices optimizations flags by returning an error, just > log it and carry on. > > Fixes: 80580

[dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set

2018-07-27 Thread Luca Boccassi
rx_drop_en is an optimization that does nothing on single-queue devices like e1000. Do not force applications that do not care to select per-devices optimizations flags by returning an error, just log it and carry on. Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)") C