Re: [dpdk-dev] [PATCH] net/cxgbe: fix colliding function names

2019-04-19 Thread Ferruh Yigit
On 4/19/2019 11:04 AM, Rahul Lakkireddy wrote: > On Friday, April 04/19/19, 2019 at 05:07:02 +0530, Stephen Hemminger wrote: >> This driver defines lots of functions (like init_rss) which are intended >> to only be used in this device. But when doing static linking these >> global functions cause l

Re: [dpdk-dev] [PATCH] net/cxgbe: fix colliding function names

2019-04-19 Thread Rahul Lakkireddy
On Friday, April 04/19/19, 2019 at 13:45:12 +0530, Ferruh Yigit wrote: > On 4/19/2019 12:37 AM, Stephen Hemminger wrote: > > This driver defines lots of functions (like init_rss) which are intended > > to only be used in this device. But when doing static linking these > > global functions cause li

Re: [dpdk-dev] [PATCH] net/cxgbe: fix colliding function names

2019-04-19 Thread Rahul Lakkireddy
On Friday, April 04/19/19, 2019 at 05:07:02 +0530, Stephen Hemminger wrote: > This driver defines lots of functions (like init_rss) which are intended > to only be used in this device. But when doing static linking these > global functions cause link failures when similar function name is > used in

Re: [dpdk-dev] [PATCH] net/cxgbe: fix colliding function names

2019-04-19 Thread Ferruh Yigit
On 4/19/2019 12:37 AM, Stephen Hemminger wrote: > This driver defines lots of functions (like init_rss) which are intended > to only be used in this device. But when doing static linking these > global functions cause link failures when similar function name is > used in application. > > This patc

[dpdk-dev] [PATCH] net/cxgbe: fix colliding function names

2019-04-18 Thread Stephen Hemminger
This driver defines lots of functions (like init_rss) which are intended to only be used in this device. But when doing static linking these global functions cause link failures when similar function name is used in application. This patch prefixes all functions defined in cxgbe.h with cxgbe_ to a