Re: [dpdk-dev] [PATCH] net/bonding: fix socket id check

2021-04-27 Thread Ferruh Yigit
On 4/27/2021 3:44 AM, Chengchang Tang wrote: > > > On 2021/4/26 22:54, Ferruh Yigit wrote: >> On 4/22/2021 8:12 AM, Min Hu (Connor) wrote: >>> From: Chengchang Tang >>> >>> The socket ID entered by user is cast to an unsigned integer. However, >>> the value may be an illegal negative value, whic

Re: [dpdk-dev] [PATCH] net/bonding: fix socket id check

2021-04-26 Thread Chengchang Tang
On 2021/4/26 22:54, Ferruh Yigit wrote: > On 4/22/2021 8:12 AM, Min Hu (Connor) wrote: >> From: Chengchang Tang >> >> The socket ID entered by user is cast to an unsigned integer. However, >> the value may be an illegal negative value, which may cause some >> problems. In this case, an error sh

Re: [dpdk-dev] [PATCH] net/bonding: fix socket id check

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 8:12 AM, Min Hu (Connor) wrote: > From: Chengchang Tang > > The socket ID entered by user is cast to an unsigned integer. However, > the value may be an illegal negative value, which may cause some > problems. In this case, an error should be returned. > +1 to fix > In addition, t

[dpdk-dev] [PATCH] net/bonding: fix socket id check

2021-04-22 Thread Min Hu (Connor)
From: Chengchang Tang The socket ID entered by user is cast to an unsigned integer. However, the value may be an illegal negative value, which may cause some problems. In this case, an error should be returned. In addition, the socket ID may be an invalid positive number, which is also processed

Re: [dpdk-dev] [PATCH] net/bonding: fix socket id check

2020-07-09 Thread Ferruh Yigit
On 6/16/2020 11:09 AM, Chas Williams wrote: > On 6/16/20 5:46 AM, David Marchand wrote: >> Caught by code review, rte_eth_dev_socket_id() returns -1 on error. >> The code should behave the same, but still, do not use LCORE_ID_ANY for >> something that is not a lcore id. >> >> Fixes: c15c5897340d (

Re: [dpdk-dev] [PATCH] net/bonding: fix socket id check

2020-06-16 Thread Chas Williams
Acked-by: Chas Williams On 6/16/20 5:46 AM, David Marchand wrote: Caught by code review, rte_eth_dev_socket_id() returns -1 on error. The code should behave the same, but still, do not use LCORE_ID_ANY for something that is not a lcore id. Fixes: c15c5897340d ("net/bonding: avoid allocating me

[dpdk-dev] [PATCH] net/bonding: fix socket id check

2020-06-16 Thread David Marchand
Caught by code review, rte_eth_dev_socket_id() returns -1 on error. The code should behave the same, but still, do not use LCORE_ID_ANY for something that is not a lcore id. Fixes: c15c5897340d ("net/bonding: avoid allocating mempool on unknown socket") Cc: sta...@dpdk.org Signed-off-by: David Ma