Re: [dpdk-dev] [PATCH] net/ark: fix meson build

2020-08-21 Thread Ferruh Yigit
On 8/20/2020 4:41 PM, Ed Czeck wrote: > On Thu, Aug 20, 2020 at 7:16 AM Ferruh Yigit wrote: >> > ... >> >> Logging can be controlled in runtime, that is what we should use. >> In data path, we use compile time flags because of the performance issues. >> So OK >> to have 'CONFIG_RTE_LIBRTE_ARK_DEB

Re: [dpdk-dev] [PATCH] net/ark: fix meson build

2020-08-20 Thread Ed Czeck
On Thu, Aug 20, 2020 at 7:16 AM Ferruh Yigit wrote: > ... > > Logging can be controlled in runtime, that is what we should use. > In data path, we use compile time flags because of the performance issues. So > OK > to have 'CONFIG_RTE_LIBRTE_ARK_DEBUG_RX' & 'CONFIG_RTE_LIBRTE_ARK_DEBUG_TX' as > c

Re: [dpdk-dev] [PATCH] net/ark: fix meson build

2020-08-20 Thread Ferruh Yigit
On 8/19/2020 9:45 PM, Ed Czeck wrote: > * Rename net/ark specific CONFIG_RTE macros to local macros. > * Change condition of ARK_PAD_TX to match behavior of meson build > to makefile build. > * Install header file needed for dynamic library. > * Update doc as required. > > Signed-off-by: Ed Czeck

[dpdk-dev] [PATCH] net/ark: fix meson build

2020-08-19 Thread Ed Czeck
* Rename net/ark specific CONFIG_RTE macros to local macros. * Change condition of ARK_PAD_TX to match behavior of meson build to makefile build. * Install header file needed for dynamic library. * Update doc as required. Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 24 +

Re: [dpdk-dev] [PATCH] net/ark: fix meson build

2020-08-19 Thread Ferruh Yigit
On 8/19/2020 4:35 PM, Ed Czeck wrote: > * Set RTE_LIBRTE_ARK_PAD_TX in local meson.build to match > the CONFIG_RTE_LIBRTE_ARK_PAD_TX setting used in make. > * Install header file needed for dynamic library. > > Signed-off-by: Ed Czeck > --- > drivers/net/ark/meson.build | 3 +++ > 1 file changed

[dpdk-dev] [PATCH] net/ark: fix meson build

2020-08-19 Thread Ed Czeck
* Set RTE_LIBRTE_ARK_PAD_TX in local meson.build to match the CONFIG_RTE_LIBRTE_ARK_PAD_TX setting used in make. * Install header file needed for dynamic library. Signed-off-by: Ed Czeck --- drivers/net/ark/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ark/meson.