Re: [dpdk-dev] [PATCH] net/af_xdp: submit valid count to Tx queue

2019-04-11 Thread Ye Xiaolong
On 04/11, David Marchand wrote: >Hello Xiaolong, > >On Thu, Apr 11, 2019 at 4:30 AM Ye Xiaolong wrote: > >> On 04/10, David Marchand wrote: >> >If we reserve N slots, but only submit n slots, we end up with an >> incorrect >> >opinion of the number of available slots later. >> >Either xsk_ring_pro

Re: [dpdk-dev] [PATCH] net/af_xdp: submit valid count to Tx queue

2019-04-11 Thread David Marchand
Hello Xiaolong, On Thu, Apr 11, 2019 at 4:30 AM Ye Xiaolong wrote: > On 04/10, David Marchand wrote: > >If we reserve N slots, but only submit n slots, we end up with an > incorrect > >opinion of the number of available slots later. > >Either xsk_ring_prod__submit should also update cached_prod

Re: [dpdk-dev] [PATCH] net/af_xdp: submit valid count to Tx queue

2019-04-10 Thread Ye Xiaolong
On 04/10, David Marchand wrote: >On Wed, Apr 10, 2019 at 12:58 PM Xiaolong Ye wrote: > >> Since tx callback only picks mbufs that can be copied to the xdp desc, it >> should call xsk_ring_prod__submit with valid count other than nb_pkts. >> >> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD

Re: [dpdk-dev] [PATCH] net/af_xdp: submit valid count to Tx queue

2019-04-10 Thread David Marchand
On Wed, Apr 10, 2019 at 12:58 PM Xiaolong Ye wrote: > Since tx callback only picks mbufs that can be copied to the xdp desc, it > should call xsk_ring_prod__submit with valid count other than nb_pkts. > > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") > > Reported-by: David Marchand >

[dpdk-dev] [PATCH] net/af_xdp: submit valid count to Tx queue

2019-04-10 Thread Xiaolong Ye
Since tx callback only picks mbufs that can be copied to the xdp desc, it should call xsk_ring_prod__submit with valid count other than nb_pkts. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Reported-by: David Marchand Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp