Re: [dpdk-dev] [PATCH] net/af_xdp: fix integer overflow in umem size calculation

2020-10-30 Thread Ferruh Yigit
On 10/29/2020 12:41 PM, Martin Weiser wrote: Hi, the reason why I stumbled across this issue is because I was getting inconsistent errors during interface rx queue setup. We generally use quite large mempools and it looks like the umem setup fails for larger sizes. But because of the integer ove

Re: [dpdk-dev] [PATCH] net/af_xdp: fix integer overflow in umem size calculation

2020-10-29 Thread Martin Weiser
Hi, the reason why I stumbled across this issue is because I was getting inconsistent errors during interface rx queue setup. We generally use quite large mempools and it looks like the umem setup fails for larger sizes. But because of the integer overflow the umem_size sometimes became small enou

[dpdk-dev] [PATCH] net/af_xdp: fix integer overflow in umem size calculation

2020-10-29 Thread Martin Weiser
The multiplication of two u32 integers may cause an overflow with large mempool sizes. Fixes: 74b46340e2d4 ("net/af_xdp: support shared UMEM") Cc: ciara.lof...@intel.com Signed-off-by: Martin Weiser --- drivers/net/af_xdp/rte_eth_af_xdp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)