Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-10-05 Thread Ferruh Yigit
On 9/25/2017 1:53 PM, Ferruh Yigit wrote: > On 9/25/2017 1:52 PM, Ferruh Yigit wrote: >> On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: >>> Failure happens on build using: >>> gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) >>> >>> Fixes: 0d16c17ae7a4 ("net/af_packet: make qdisc bypass configurable") >>>

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Thomas Monjalon
25/09/2017 12:06, Ferruh Yigit: > On 9/25/2017 10:53 AM, Ferruh Yigit wrote: > > On 9/25/2017 10:40 AM, Bruce Richardson wrote: > >> On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote: > >>> It is a little to late for this, I already sent a pull-request with this > >>> patch. So fix will

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 1:52 PM, Ferruh Yigit wrote: > On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: >> Failure happens on build using: >> gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) >> >> Fixes: 0d16c17ae7a4 ("net/af_packet: make qdisc bypass configurable") >> >> Signed-off-by: Andrew Rybchenko > > Reviewed

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: > Failure happens on build using: > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) > > Fixes: 0d16c17ae7a4 ("net/af_packet: make qdisc bypass configurable") > > Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 11:06 AM, Ferruh Yigit wrote: > On 9/25/2017 10:53 AM, Ferruh Yigit wrote: >> On 9/25/2017 10:40 AM, Bruce Richardson wrote: >>> On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote: On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: > Failure happens on build using: >

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 10:53 AM, Ferruh Yigit wrote: > On 9/25/2017 10:40 AM, Bruce Richardson wrote: >> On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote: >>> On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: Failure happens on build using: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) >>> >>>

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 10:40 AM, Bruce Richardson wrote: > On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote: >> On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: >>> Failure happens on build using: >>> gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) >> >> Yes, that case is missed. What do you think about

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Bruce Richardson
On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote: > On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: > > Failure happens on build using: > > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) > > Yes, that case is missed. What do you think about following one: > > @@ -561,7 +561,7 @@ rte_pmd_i

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Andrew Rybchenko
On 09/25/2017 11:42 AM, Ferruh Yigit wrote: On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: Failure happens on build using: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) Yes, that case is missed. What do you think about following one: @@ -561,7 +561,7 @@ rte_pmd_init_internals(struct rte_vdev_de

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: > Failure happens on build using: > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) Yes, that case is missed. What do you think about following one: @@ -561,7 +561,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, unsigne

[dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-24 Thread Andrew Rybchenko
Failure happens on build using: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) Fixes: 0d16c17ae7a4 ("net/af_packet: make qdisc bypass configurable") Signed-off-by: Andrew Rybchenko --- May be the right solution in fact remove PACKET_QDISC_BYPASS conditional completely. If below solution is accepted,