Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-03-20 Thread Olivier Matz
Hi Robin, On Fri, 17 Mar 2017 18:47:20 +0100, Robin Jarry wrote: > Hi Olivier, > > Thanks again for this. I only have minor cosmetic remarks: > > Le 17 mars 2017 18:13, "Olivier Matz" a écrit: > > diff --git a/app/pdump/Makefile b/app/pdump/Makefile > > index 536198f..8ec6bd6 100644 > > --- a/

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-03-17 Thread Robin Jarry
Hi Olivier, Thanks again for this. I only have minor cosmetic remarks: Le 17 mars 2017 18:13, "Olivier Matz" a écrit: > diff --git a/app/pdump/Makefile b/app/pdump/Makefile > index 536198f..8ec6bd6 100644 > --- a/app/pdump/Makefile > +++ b/app/pdump/Makefile > @@ -42,7 +42,6 @@ CFLAGS += $(WERRO

[dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-03-17 Thread Olivier Matz
Before this patch, the management of dependencies between directories had several issues: - the generation of .depdirs, done at configuration is slow: it can take more than one minute on some slow targets (usually ~10s on a standard PC without -j). - for instance, it is possible to express a

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-03-01 Thread Olivier Matz
On Wed, 01 Mar 2017 12:25:45 +0100, Thomas Monjalon wrote: > 2017-01-24 14:55, Wiles, Keith: > > > On Jan 24, 2017, at 7:50 AM, Olivier MATZ wrote: > > > On Tue, 24 Jan 2017 13:26:41 +, "Richardson, Bruce" > > > wrote: > > >> > > >> Ok. Point taken for the lower-core count parts. > > >>

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-03-01 Thread Bruce Richardson
On Wed, Mar 01, 2017 at 12:25:45PM +0100, Thomas Monjalon wrote: > 2017-01-24 14:55, Wiles, Keith: > > > On Jan 24, 2017, at 7:50 AM, Olivier MATZ wrote: > > > On Tue, 24 Jan 2017 13:26:41 +, "Richardson, Bruce" > > > wrote: > > >> > > >> Ok. Point taken for the lower-core count parts. > > >

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-03-01 Thread Thomas Monjalon
2017-01-24 14:55, Wiles, Keith: > > On Jan 24, 2017, at 7:50 AM, Olivier MATZ wrote: > > On Tue, 24 Jan 2017 13:26:41 +, "Richardson, Bruce" > > wrote: > >> > >> Ok. Point taken for the lower-core count parts. > >> > >> Thomas - can at least one of these patches be merged into 17.02, > >> s

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-01-24 Thread Wiles, Keith
> On Jan 24, 2017, at 7:50 AM, Olivier MATZ wrote: > > On Tue, 24 Jan 2017 13:26:41 +, "Richardson, Bruce" > wrote: >> >> Ok. Point taken for the lower-core count parts. >> >> Thomas - can at least one of these patches be merged into 17.02, >> since it will definitely help us developers?

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-01-24 Thread Olivier MATZ
On Tue, 24 Jan 2017 13:26:41 +, "Richardson, Bruce" wrote: > > Ok. Point taken for the lower-core count parts. > > Thomas - can at least one of these patches be merged into 17.02, > since it will definitely help us developers? [If Olivier's is too big > a change at this point in the cycle, c

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-01-24 Thread Richardson, Bruce
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Tuesday, January 24, 2017 12:57 PM > To: Richardson, Bruce > Cc: Olivier Matz ; dev@dpdk.org; Yigit, Ferruh > ; thomas.monja...@6wind.com > Subject: Re: [dpdk-dev] [PATCH] m

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-01-24 Thread Ferruh Yigit
On 1/23/2017 5:19 PM, Olivier Matz wrote: > Before this patch, the management of dependencies between directories > had several issues: > > - the generation of .depdirs, done at configuration is slow: it can take > more than one minute on some slow targets (usually ~10s on a standard > PC). >

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-01-24 Thread Jerin Jacob
On Tue, Jan 24, 2017 at 12:15:06PM +, Bruce Richardson wrote: > On Tue, Jan 24, 2017 at 05:10:15PM +0530, Jerin Jacob wrote: > > On Mon, Jan 23, 2017 at 06:19:13PM +0100, Olivier Matz wrote: > > > Before this patch, the management of dependencies between directories > > > had several issues: >

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-01-24 Thread Robin Jarry
Hi Bruce, 2017-01-24, Bruce Richardson: what are the differences in the patches like when doing a build rather than just a config? If the build is minutes long because of slow IO, is the extra 10 seconds really going to make that much of a difference? I agree there is no significant difference

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-01-24 Thread Bruce Richardson
On Tue, Jan 24, 2017 at 05:10:15PM +0530, Jerin Jacob wrote: > On Mon, Jan 23, 2017 at 06:19:13PM +0100, Olivier Matz wrote: > > Before this patch, the management of dependencies between directories > > had several issues: > > > > - the generation of .depdirs, done at configuration is slow: it can

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-01-24 Thread Jerin Jacob
On Mon, Jan 23, 2017 at 06:19:13PM +0100, Olivier Matz wrote: > Before this patch, the management of dependencies between directories > had several issues: > > - the generation of .depdirs, done at configuration is slow: it can take > more than one minute on some slow targets (usually ~10s on a

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-01-24 Thread Bruce Richardson
On Tue, Jan 24, 2017 at 12:19:49PM +0100, Robin Jarry wrote: > Hi Olivier, > > 2017-01-23, Olivier Matz: > > Before this patch, the management of dependencies between directories > > had several issues: > > > > - the generation of .depdirs, done at configuration is slow: it can take > > more tha

Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-01-24 Thread Robin Jarry
Hi Olivier, 2017-01-23, Olivier Matz: Before this patch, the management of dependencies between directories had several issues: - the generation of .depdirs, done at configuration is slow: it can take more than one minute on some slow targets (usually ~10s on a standard PC). Indeed, on a Qu

[dpdk-dev] [PATCH] mk: optimize directory dependencies

2017-01-23 Thread Olivier Matz
Before this patch, the management of dependencies between directories had several issues: - the generation of .depdirs, done at configuration is slow: it can take more than one minute on some slow targets (usually ~10s on a standard PC). - for instance, it is possible to expressed a dependenc