Re: [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86

2019-12-27 Thread Olivier Matz
Hi, On Sat, Dec 21, 2019 at 10:36:15AM +0530, Jerin Jacob wrote: > On Sat, Dec 21, 2019 at 2:37 AM Honnappa Nagarahalli > wrote: > > > > > > > > > From: Jerin Jacob > > > > > > > > > > The exiting optimize_object_size() function address the memory > > > > > object alignment constraint on x86 fo

Re: [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86

2019-12-20 Thread Jerin Jacob
On Sat, Dec 21, 2019 at 2:37 AM Honnappa Nagarahalli wrote: > > > > > > From: Jerin Jacob > > > > > > > > The exiting optimize_object_size() function address the memory > > > > object alignment constraint on x86 for better performance. > > > > > > > > Different (Mirco) architecture may have diff

Re: [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86

2019-12-20 Thread Honnappa Nagarahalli
> > > From: Jerin Jacob > > > > > > The exiting optimize_object_size() function address the memory > > > object alignment constraint on x86 for better performance. > > > > > > Different (Mirco) architecture may have different memory alignment > > > constraint for better performance and it not sam

Re: [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86

2019-12-20 Thread Jerin Jacob
On Fri, Dec 20, 2019 at 9:25 PM Honnappa Nagarahalli wrote: > > > > > > > From: Jerin Jacob > > > > The exiting optimize_object_size() function address the memory object > > alignment constraint on x86 for better performance. > > > > Different (Mirco) architecture may have different memory align

Re: [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86

2019-12-20 Thread Honnappa Nagarahalli
> > From: Jerin Jacob > > The exiting optimize_object_size() function address the memory object > alignment constraint on x86 for better performance. > > Different (Mirco) architecture may have different memory alignment > constraint for better performance and it not same as the existing > op

Re: [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86

2019-12-19 Thread Jerin Jacob
On Fri, Dec 20, 2019 at 8:56 AM Gavin Hu wrote: > > Hi Jerin, > > It got two coding style warnings, otherwise, > Reviewed-by: Gavin Hu Thanks Gavin for review. Since the existing code is using "unsigned" in that file, I thought of not change by this patch. If someone thinks, It is better to chan

Re: [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86

2019-12-19 Thread Gavin Hu
Hi Jerin, It got two coding style warnings, otherwise, Reviewed-by: Gavin Hu WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #144: FILE: lib/librte_mempool/rte_mempool.c:84: +arch_mem_object_align(unsigned obj_size) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bar

[dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86

2019-12-19 Thread jerinj
From: Jerin Jacob The exiting optimize_object_size() function address the memory object alignment constraint on x86 for better performance. Different (Mirco) architecture may have different memory alignment constraint for better performance and it not same as the existing optimize_object_size()