Re: [dpdk-dev] [PATCH] mempool: enforce valid flags at creation

2021-10-14 Thread David Marchand
On Tue, Oct 12, 2021 at 9:57 AM David Marchand wrote: > > On Tue, Oct 12, 2021 at 9:49 AM Andrew Rybchenko > wrote: > > > > On 10/12/21 10:28 AM, David Marchand wrote: > > > If we do not enforce valid flags are passed by an application, this > > > application might face issues in the future when

Re: [dpdk-dev] [PATCH] mempool: enforce valid flags at creation

2021-10-12 Thread Kinsella, Ray
On 12/10/2021 08:28, David Marchand wrote: > If we do not enforce valid flags are passed by an application, this > application might face issues in the future when we add more flags. > > Signed-off-by: David Marchand > --- Acked-by: Ray Kinsella

Re: [dpdk-dev] [PATCH] mempool: enforce valid flags at creation

2021-10-12 Thread David Marchand
On Tue, Oct 12, 2021 at 9:49 AM Andrew Rybchenko wrote: > > On 10/12/21 10:28 AM, David Marchand wrote: > > If we do not enforce valid flags are passed by an application, this > > application might face issues in the future when we add more flags. > > Thanks. I'd even consider it as a bug and the

Re: [dpdk-dev] [PATCH] mempool: enforce valid flags at creation

2021-10-12 Thread Andrew Rybchenko
On 10/12/21 10:28 AM, David Marchand wrote: > If we do not enforce valid flags are passed by an application, this > application might face issues in the future when we add more flags. Thanks. I'd even consider it as a bug and the fix to be backported. > > Signed-off-by: David Marchand A nit be

[dpdk-dev] [PATCH] mempool: enforce valid flags at creation

2021-10-12 Thread David Marchand
If we do not enforce valid flags are passed by an application, this application might face issues in the future when we add more flags. Signed-off-by: David Marchand --- app/test/test_mempool.c | 21 + lib/mempool/rte_mempool.c | 13 + lib/mempool/rte_mempool.h