Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-10 Thread Olivier Matz
On Sun, Nov 08, 2020 at 02:19:55PM +, Ananyev, Konstantin wrote: > > > > >> > > >> Hi Olivier, > > >> > > >>> m->nb_seg must be reset on mbuf free > > whatever > > >> the > > value > > >> of m->next, > > >>>

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-08 Thread Ananyev, Konstantin
> >> > >> Hi Olivier, > >> > >>> m->nb_seg must be reset on mbuf free > whatever > >> the > value > >> of m->next, > >>> because it can happen that m->nb_seg is > >> != > 1. > >> For > >> in

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-08 Thread Andrew Rybchenko
On 11/6/20 3:23 PM, Morten Brørup wrote: From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] Sent: Friday, November 6, 2020 12:54 PM Hi Olivier, m->nb_seg must be reset on mbuf free whatever the value of m->next, because it can happen that m->nb_seg is != 1. For instance

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-07 Thread Ali Alnubani
Hi Olivier, > -Original Message- > From: dev On Behalf Of Olivier Matz > Sent: Wednesday, November 4, 2020 7:00 PM > To: dev@dpdk.org > Cc: konstantin.anan...@intel.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free > I can reproduce t

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-06 Thread Morten Brørup
> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Friday, November 6, 2020 12:54 PM > > > > > > > > > > > > > > > > >> Hi Olivier, > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >>> m->nb_seg must be reset on mbuf free > > > whatever > > > > > the > > > > >

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-06 Thread Ananyev, Konstantin
> > > > > > > > > > > > > > >> Hi Olivier, > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >>> m->nb_seg must be reset on mbuf free > > whatever > > > > the > > > > > > value > > > > > > > > of m->next, > > > > > > > > > > > > > > >>> because it can happen that m->nb_seg is != > > 1. >

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-06 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, November 6, 2020 11:05 AM > > On Fri, Nov 06, 2020 at 09:50:45AM +0100, Morten Brørup wrote: > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > Sent: Friday, November 6, 2020 9:21 AM > > > > > > On Fri, Nov 06, 2020 a

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-06 Thread Olivier Matz
On Fri, Nov 06, 2020 at 09:50:45AM +0100, Morten Brørup wrote: > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Friday, November 6, 2020 9:21 AM > > > > On Fri, Nov 06, 2020 at 08:52:58AM +0100, Morten Brørup wrote: > > > > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-06 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, November 6, 2020 9:21 AM > > On Fri, Nov 06, 2020 at 08:52:58AM +0100, Morten Brørup wrote: > > > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > > > Sent: Friday, November 6, 2020 12:55 AM > > > > > > > > > > >

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-06 Thread Olivier Matz
On Fri, Nov 06, 2020 at 08:52:58AM +0100, Morten Brørup wrote: > > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > > Sent: Friday, November 6, 2020 12:55 AM > > > > > > > > > > > > >> Hi Olivier, > > > > > > > > > > >> > > > > > > > > > > >>> m->nb_seg must be reset on mbuf free

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Morten Brørup
> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Friday, November 6, 2020 12:55 AM > > > > > > > > > > >> Hi Olivier, > > > > > > > > > >> > > > > > > > > > >>> m->nb_seg must be reset on mbuf free whatever the > value > > > of m->next, > > > > > > > > > >>> because it can

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Ananyev, Konstantin
> > > > > > > > >> Hi Olivier, > > > > > > > > >> > > > > > > > > >>> m->nb_seg must be reset on mbuf free whatever the value > > of m->next, > > > > > > > > >>> because it can happen that m->nb_seg is != 1. For > > instance in this > > > > > > > > >>> case: > > > > > > > > >>> > > > > > > > > >>

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, > Konstantin > Sent: Thursday, November 5, 2020 2:56 PM > > > > > > > > > > > > On Thu, Nov 05, 2020 at 11:34:18AM +, Ananyev, Konstantin > wrote: > > > > > > > > > > > > > > > > On Thu, Nov 05, 2020 at 11:26:51AM +0300, Andrew Ry

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Ananyev, Konstantin
> > > > > > > > On Thu, Nov 05, 2020 at 11:34:18AM +, Ananyev, Konstantin wrote: > > > > > > > > > > > > > On Thu, Nov 05, 2020 at 11:26:51AM +0300, Andrew Rybchenko wrote: > > > > > > On 11/5/20 10:46 AM, Olivier Matz wrote: > > > > > > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, K

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Olivier Matz
On Thu, Nov 05, 2020 at 01:14:07PM +, Ananyev, Konstantin wrote: > > > > > > On Thu, Nov 05, 2020 at 11:34:18AM +, Ananyev, Konstantin wrote: > > > > > > > > > > On Thu, Nov 05, 2020 at 11:26:51AM +0300, Andrew Rybchenko wrote: > > > > > On 11/5/20 10:46 AM, Olivier Matz wrote: > > > > >

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Ananyev, Konstantin
> > On Thu, Nov 05, 2020 at 11:34:18AM +, Ananyev, Konstantin wrote: > > > > > > > On Thu, Nov 05, 2020 at 11:26:51AM +0300, Andrew Rybchenko wrote: > > > > On 11/5/20 10:46 AM, Olivier Matz wrote: > > > > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: > > > > >> > >

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Olivier Matz
On Thu, Nov 05, 2020 at 11:34:18AM +, Ananyev, Konstantin wrote: > > > > On Thu, Nov 05, 2020 at 11:26:51AM +0300, Andrew Rybchenko wrote: > > > On 11/5/20 10:46 AM, Olivier Matz wrote: > > > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: > > > >> > > > >> Hi Olivier,

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Ananyev, Konstantin
> On Thu, Nov 05, 2020 at 11:26:51AM +0300, Andrew Rybchenko wrote: > > On 11/5/20 10:46 AM, Olivier Matz wrote: > > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: > > >> > > >> Hi Olivier, > > >> > > >>> m->nb_seg must be reset on mbuf free whatever the value of m->next,

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Olivier Matz
On Thu, Nov 05, 2020 at 11:26:51AM +0300, Andrew Rybchenko wrote: > On 11/5/20 10:46 AM, Olivier Matz wrote: > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: > >> > >> Hi Olivier, > >> > >>> m->nb_seg must be reset on mbuf free whatever the value of m->next, > >>> because

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Andrew Rybchenko
Just resend with lost Cc restored. On 11/5/20 10:46 AM, Olivier Matz wrote: > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: >> >> Hi Olivier, >> >>> m->nb_seg must be reset on mbuf free whatever the value of m->next, >>> because it can happen that m->nb_seg is != 1. For in

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Olivier Matz
On Thu, Nov 05, 2020 at 09:33:58AM +0100, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > > Sent: Thursday, November 5, 2020 8:46 AM > > > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: > > > > > > Hi Olivier, > > > > > > > m->nb

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Thursday, November 5, 2020 8:46 AM > > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: > > > > Hi Olivier, > > > > > m->nb_seg must be reset on mbuf free whatever the value of m->next, > > > because it

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-05 Thread Andrew Rybchenko
On 11/5/20 10:46 AM, Olivier Matz wrote: > On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: >> >> Hi Olivier, >> >>> m->nb_seg must be reset on mbuf free whatever the value of m->next, >>> because it can happen that m->nb_seg is != 1. For instance in this >>> case: >>> >>> m

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-04 Thread Olivier Matz
On Thu, Nov 05, 2020 at 12:15:49AM +, Ananyev, Konstantin wrote: > > Hi Olivier, > > > m->nb_seg must be reset on mbuf free whatever the value of m->next, > > because it can happen that m->nb_seg is != 1. For instance in this > > case: > > > > m1 = rte_pktmbuf_alloc(mp); > > rte_pktmbuf

Re: [dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-04 Thread Ananyev, Konstantin
Hi Olivier, > m->nb_seg must be reset on mbuf free whatever the value of m->next, > because it can happen that m->nb_seg is != 1. For instance in this > case: > > m1 = rte_pktmbuf_alloc(mp); > rte_pktmbuf_append(m1, 500); > m2 = rte_pktmbuf_alloc(mp); > rte_pktmbuf_append(m2, 500); >

[dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-04 Thread Olivier Matz
m->nb_seg must be reset on mbuf free whatever the value of m->next, because it can happen that m->nb_seg is != 1. For instance in this case: m1 = rte_pktmbuf_alloc(mp); rte_pktmbuf_append(m1, 500); m2 = rte_pktmbuf_alloc(mp); rte_pktmbuf_append(m2, 500); rte_pktmbuf_chain(m1, m2); m0 =