[dpdk-dev] [PATCH] mbuf: decrease refcnt when detaching

2016-05-17 Thread Hiroyuki MIKITA
Hi all, Thanks for suggestions. I think the Oliver's first option is good. I introduce the new function and will replace rte_pktmbuf_detach() with it in a future release. 2016-05-16 18:13 GMT+09:00 Thomas Monjalon : > 2016-05-16 11:46, Hiroyuki MIKITA: >> Now, the attach operation increases refc

[dpdk-dev] [PATCH] mbuf: decrease refcnt when detaching

2016-05-16 Thread Hiroyuki MIKITA
; > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Hiroyuki Mikita >> Sent: Sunday, May 15, 2016 4:51 PM >> To: olivier.matz at 6wind.com >> Cc: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] mbuf: decrease refcnt when detac

[dpdk-dev] [PATCH] mbuf: decrease refcnt when detaching

2016-05-16 Thread Thomas Monjalon
2016-05-16 11:46, Hiroyuki MIKITA: > Now, the attach operation increases refcnt, but the detach does not decrease > it. > I think both operations should affect refcnt or not. > Which design is intended? > > In "6.7. Direct and Indirect Buffers" of Programmer's Guide, > it is mentioned that "...wh

[dpdk-dev] [PATCH] mbuf: decrease refcnt when detaching

2016-05-16 Thread Olivier Matz
Hi Hiroyuki, On 05/15/2016 05:50 PM, Hiroyuki Mikita wrote: > The rte_pktmbuf_detach() function should decrease refcnt on a direct > buffer. > > Signed-off-by: Hiroyuki Mikita > --- > lib/librte_mbuf/rte_mbuf.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/li

[dpdk-dev] [PATCH] mbuf: decrease refcnt when detaching

2016-05-16 Thread Ananyev, Konstantin
> >> -Original Message- > >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Hiroyuki Mikita > >> Sent: Sunday, May 15, 2016 4:51 PM > >> To: olivier.matz at 6wind.com > >> Cc: dev at dpdk.org > >> Subject: [dpdk-dev] [PATC

[dpdk-dev] [PATCH] mbuf: decrease refcnt when detaching

2016-05-16 Thread Hiroyuki Mikita
The rte_pktmbuf_detach() function should decrease refcnt on a direct buffer. Signed-off-by: Hiroyuki Mikita --- lib/librte_mbuf/rte_mbuf.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 529debb..3b117ca 100644

[dpdk-dev] [PATCH] mbuf: decrease refcnt when detaching

2016-05-16 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Hiroyuki Mikita > Sent: Sunday, May 15, 2016 4:51 PM > To: olivier.matz at 6wind.com > Cc: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] mbuf: decrease refcnt when detaching > >